Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16256: Properly get tab origin for brave shields. #9078

Merged
merged 1 commit into from
Jun 10, 2021
Merged

16256: Properly get tab origin for brave shields. #9078

merged 1 commit into from
Jun 10, 2021

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Jun 10, 2021 •
edited by kjozwiak
Loading

MANUAL Uplift of #9038
Fixes brave/brave-browser#16265

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@iefremov iefremov requested review from mariospr and a team June 10, 2021 13:14
@iefremov
Copy link
Contributor Author

@mariospr could you please take an extra look? This is a manual uplift

@kjozwiak
Copy link
Member

Restarting Linux due to timing out as per https://ci.brave.com/job/pr-brave-browser-manual_pr9038_ie_tab_origin_1.25.x-linux/1/console.

11:19:05  [187/227] STAMP obj/brave/brave_dist_resources.stamp
Body did not finish within grace period; terminating with extreme prejudice

@kjozwiak kjozwiak added this to the 1.25.x - Release #5 milestone Jun 10, 2021
kjozwiak
kjozwiak approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9038 (comment).

@kjozwiak kjozwiak merged commit 4f1c317 into 1.25.x Jun 10, 2021
@kjozwiak kjozwiak deleted the manual_pr9038_ie_tab_origin_1.25.x branch June 10, 2021 18:07
@kjozwiak kjozwiak mentioned this pull request Jun 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@mariospr mariospr Awaiting requested review from mariospr

Assignees

@iefremov iefremov

Labels
None yet
Projects
None yet
Milestone
1.25.x - Release #5
Development

Successfully merging this pull request may close these issues.
2 participants
@iefremov @kjozwiak