brave_stats: Create preference to disable ping #9229

kkuehlz · 2021-06-24T01:42:51Z

Resolves brave/brave-browser#16583

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issue

emerick

LGTM

diracdeltas · 2021-06-24T22:12:05Z

UI lgtm but i didn't see any usage pings with or without the setting enabled. what's the expected IP of the ping?

kkuehlz · 2021-06-24T22:39:53Z

UI lgtm but i didn't see any usage pings with or without the setting enabled. what's the expected IP of the ping?

I think since you are on a dev build it's not set. You can pass the cli flag --brave_stats_updater_url=https://vault.bsg.bravesoftware.com or set brave_stats_updater_url in .npmrc. Needs VPN. Also the ping on dev builds will 4xx because channel is set to developer, so that is expected.

diracdeltas · 2021-06-25T06:25:28Z

You can pass the cli flag --brave_stats_updater_url=https://vault.bsg.bravesoftware.com or set brave_stats_updater_url in .npmrc

i tried both and still no pings. npm start runs the build with --disable-brave-update though, not sure if that matters.

browser/resources/settings/brave_privacy_page/brave_personalization_options.js

kkuehlz · 2021-06-29T20:05:43Z

@diracdeltas the browser tests pass, which wait for the ping to fire, and i am able to see it log in the URL loader handler. You should see if you can see the ping without this patchset. If you run into any issues can follow up on Slack.

browser/ui/webui/settings/brave_privacy_handler.cc

kkuehlz · 2021-07-01T22:29:54Z

@karenkliu the screenshots you asked for

karenkliu · 2021-07-01T23:09:54Z

@keur I'm not seeing the updated text for crash reporting, the usage ping, and P3A? Also it should be ordered P3A, usage ping, then crash reporting:

karenkliu

Left a comment: #9229 (comment)

kkuehlz · 2021-07-01T23:38:20Z

cc @karenkliu

karenkliu

Perfect! 💯

simonhong

++

mkarolin

chromium_src ++

mkarolin · 2021-07-01T23:58:54Z

app/resources/brave_generated_resources_en-GB.xtb

@@ -308,8 +308,8 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
 <translation id="1872784258300710671">Brave uses completely private product analytics to estimate the overall usage of certain features</translation>


.xtb files are generated automatically when we pull translations from Transifex. There's no need to edit them.

Resolves brave/brave-browser#16583

* Usage ping text updated * P3A text updated * Crash reporting text updated Reorder these settings

kkuehlz · 2021-07-06T21:20:05Z

Test failure in ads. Unrelated

kkuehlz requested review from bridiver, emerick, diracdeltas and fmarier June 24, 2021 01:42

github-actions bot assigned kkuehlz Jun 24, 2021

kkuehlz force-pushed the stats_pref_disable_ping branch from f6d439c to 9ad9133 Compare June 24, 2021 01:44

kkuehlz requested a review from bbondy June 24, 2021 01:53

emerick approved these changes Jun 24, 2021

View reviewed changes

kkuehlz requested a review from a team as a code owner June 24, 2021 21:16

kkuehlz requested a review from simonhong June 24, 2021 21:19

kkuehlz force-pushed the stats_pref_disable_ping branch from 899d98c to b72095a Compare June 24, 2021 21:39

kkuehlz requested review from rebron and karenkliu June 25, 2021 20:59

simonhong reviewed Jun 28, 2021

View reviewed changes

browser/resources/settings/brave_privacy_page/brave_personalization_options.js Show resolved Hide resolved

kkuehlz force-pushed the stats_pref_disable_ping branch from b72095a to f0bbfc2 Compare June 29, 2021 21:56

kkuehlz requested a review from simonhong June 29, 2021 21:57

simonhong reviewed Jun 30, 2021

View reviewed changes

browser/ui/webui/settings/brave_privacy_handler.cc Outdated Show resolved Hide resolved

kkuehlz force-pushed the stats_pref_disable_ping branch from f0bbfc2 to 9780fc0 Compare July 1, 2021 20:45

karenkliu suggested changes Jul 1, 2021

View reviewed changes

kkuehlz requested a review from karenkliu July 1, 2021 23:38

karenkliu approved these changes Jul 1, 2021

View reviewed changes

kkuehlz requested a review from simonhong July 1, 2021 23:52

simonhong approved these changes Jul 1, 2021

View reviewed changes

mkarolin approved these changes Jul 1, 2021

View reviewed changes

mkarolin reviewed Jul 1, 2021

View reviewed changes

kkuehlz force-pushed the stats_pref_disable_ping branch from 5348e83 to 7a38aa6 Compare July 2, 2021 16:20

Kevin Kuehler added 4 commits July 6, 2021 08:37

brave_stats: Create preference to disable ping

c7e5ec4

Resolves brave/brave-browser#16583

settings: Add stats usage ping

429b544

settings: Notify other pages on stats toggle

a41dd6c

Update privacy settings strings

992d0af

* Usage ping text updated * P3A text updated * Crash reporting text updated Reorder these settings

kkuehlz force-pushed the stats_pref_disable_ping branch from 7a38aa6 to 992d0af Compare July 6, 2021 15:37

kkuehlz merged commit 0e2a562 into master Jul 6, 2021

kkuehlz deleted the stats_pref_disable_ping branch July 6, 2021 21:20

kkuehlz added this to the 1.28.x - Nightly milestone Jul 7, 2021

kkuehlz mentioned this pull request Jul 12, 2021

Usage ping opt out doesn't work brave/brave-browser#16378

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

brave_stats: Create preference to disable ping #9229

brave_stats: Create preference to disable ping #9229

kkuehlz commented Jun 24, 2021 •

edited

Loading

emerick left a comment

diracdeltas commented Jun 24, 2021

kkuehlz commented Jun 24, 2021 •

edited

Loading

diracdeltas commented Jun 25, 2021

kkuehlz commented Jun 29, 2021

kkuehlz commented Jul 1, 2021

karenkliu commented Jul 1, 2021

karenkliu left a comment

kkuehlz commented Jul 1, 2021

karenkliu left a comment

simonhong left a comment

mkarolin left a comment

mkarolin Jul 1, 2021

kkuehlz commented Jul 6, 2021

		@@ -308,8 +308,8 @@ By installing this extension, you are agreeing to the Google Widevine Terms of U
		<translation id="1872784258300710671">Brave uses completely private product analytics to estimate the overall usage of certain features</translation>

brave_stats: Create preference to disable ping #9229

brave_stats: Create preference to disable ping #9229

Conversation

kkuehlz commented Jun 24, 2021 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

emerick left a comment

Choose a reason for hiding this comment

diracdeltas commented Jun 24, 2021

kkuehlz commented Jun 24, 2021 • edited Loading

diracdeltas commented Jun 25, 2021

kkuehlz commented Jun 29, 2021

kkuehlz commented Jul 1, 2021

karenkliu commented Jul 1, 2021

karenkliu left a comment

Choose a reason for hiding this comment

kkuehlz commented Jul 1, 2021

karenkliu left a comment

Choose a reason for hiding this comment

simonhong left a comment

Choose a reason for hiding this comment

mkarolin left a comment

Choose a reason for hiding this comment

mkarolin Jul 1, 2021

Choose a reason for hiding this comment

kkuehlz commented Jul 6, 2021

kkuehlz commented Jun 24, 2021 •

edited

Loading

kkuehlz commented Jun 24, 2021 •

edited

Loading