Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing retry-loop in PENDING state. #9634

Merged

Conversation

szilardszaloki
Copy link
Collaborator

@szilardszaloki szilardszaloki commented Aug 3, 2021

Resolves brave/brave-browser#17316.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See Steps to Reproduce here.

@szilardszaloki szilardszaloki requested a review from a team August 3, 2021 17:34
@szilardszaloki szilardszaloki self-assigned this Aug 3, 2021
@szilardszaloki szilardszaloki requested review from bsclifton, emerick and zenparsing and removed request for a team August 3, 2021 17:34
@szilardszaloki szilardszaloki force-pushed the sszaloki-17316-fixing-retry-loop-in-pending-state branch from b14735e to 69292b3 Compare August 3, 2021 18:10
@szilardszaloki szilardszaloki requested a review from a team as a code owner August 3, 2021 18:10
@szilardszaloki szilardszaloki changed the title Fixing retry-loop in PENDING state. Fixing retry-loop in PENDING state. Aug 3, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szilardszaloki szilardszaloki merged commit eff808c into master Aug 4, 2021
@szilardszaloki szilardszaloki deleted the sszaloki-17316-fixing-retry-loop-in-pending-state branch August 4, 2021 14:14
@szilardszaloki szilardszaloki added this to the 1.29.x - Nightly milestone Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uphold retry-loop in PENDING state doesn't display PENDING UI.
3 participants