-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Chromium leftovers from sync types screen #9799
Conversation
@@ -16,6 +16,9 @@ | |||
BraveManageSyncSettingsClassAdapter(ClassVisitor visitor) { | |||
super(visitor); | |||
|
|||
deleteField(sBraveManageSyncSettingsClassName, "mTurnOffSync"); | |||
makeProtectedField(sManageSyncSettingsClassName, "mTurnOffSync"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add unit test to BytecodeTest.java to check that this variable still exist in parent class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the test at 1da5518 . Thanks for the help.
CI for Android is marked as UNSTABLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Remove Chromium leftovers from sync types screen on Android
Resolves brave/brave-browser#17580
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Data Preferences
Sign out ...
andAdvanced
UI items