Fixed first-run dialog is not launched #9849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
cr93_first_run_regression
branch
from
8d7f919
to
d79bc49
Compare
goodov
reviewed
Aug 25, 2021
chromium_src/chrome/browser/first_run/first_run_internal_posix.cc
Outdated
Show resolved
Hide resolved
fix brave/brave-browser#17667 With https://bugs.chromium.org/p/chromium/issues/detail?id=1243221, Local State file is created at the startup. When, "Local State" file is already existed ShouldShowFirstRunDialog(). Due to this, dialog is launched ramdomly only when this file is not stored in FS becfore calling ShouldShowFirstRunDialog(). Browser only tries to run this dialog when first_run::IsChromeFirstRun() is true. Checking "Local State" file again is redundant. Removed this checking.
simonhong
force-pushed
the
cr93_first_run_regression
branch
from
d79bc49
to
6ef17f9
Compare
simonhong
commented
Aug 25, 2021
| # License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
| # You can obtain one at http://mozilla.org/MPL/2.0/. | ||
|
|
||
| brave_chromium_src_chrome_browser_first_run_deps = [ "//brave/common" ] |
chromium_src/chrome/browser/first_run/first_run_internal_posix.cc
Outdated
Show resolved
Hide resolved
common/brave_paths.h
Outdated
| // Use for getting false from base::PathService::Get(). | ||
| namespace chrome { | ||
|
|
||
| enum { CHROME_PATH_INVALID = 20000 }; |
goodov
approved these changes
Aug 25, 2021
|
Merged because |
mkarolin
pushed a commit
that referenced
this pull request
Aug 25, 2021
Fixed first-run dialog is not launched
24 tasks
24 tasks
mkarolin
added a commit
that referenced
this pull request
Sep 9, 2021
This reverts commit 0b78f9e, reversing changes made to d260b6a. Reverting because upstream has fixed the first run regression via: https://chromium.googlesource.com/chromium/src.git/+/f9385e0d893916cbb16b477bdec127e56f9897da Cherry-picked into cr94 as https://chromium.googlesource.com/chromium/src/+/3f20e2edeb0adf78a6a9a6208e2e02ad3c7d8810 commit f9385e0d893916cbb16b477bdec127e56f9897da Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Aug 30 13:31:02 2021 +0000 Ignore Local State when deciding whether to show the first run dialog. The bug was caused by an experiment that causes Local State to be written to disk during startup (before the first-run-dialog-showing logic is reached) on some clients. Since Local State existed on some clients, the dialog was not shown. However, the first-run-dialog-showing logic should not depend on the presence or absence of a Local State file. This change affects some POSIX platforms running Google Chrome for the first time. This logic being removed was originally added here: https://chromiumcodereview.appspot.com/14946003/. Bug: 1221483
mkarolin
added a commit
that referenced
this pull request
Sep 11, 2021
This reverts commit 0b78f9e, reversing changes made to d260b6a. Reverting because upstream has fixed the first run regression via: https://chromium.googlesource.com/chromium/src.git/+/f9385e0d893916cbb16b477bdec127e56f9897da Cherry-picked into cr94 as https://chromium.googlesource.com/chromium/src/+/3f20e2edeb0adf78a6a9a6208e2e02ad3c7d8810 commit f9385e0d893916cbb16b477bdec127e56f9897da Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Aug 30 13:31:02 2021 +0000 Ignore Local State when deciding whether to show the first run dialog. The bug was caused by an experiment that causes Local State to be written to disk during startup (before the first-run-dialog-showing logic is reached) on some clients. Since Local State existed on some clients, the dialog was not shown. However, the first-run-dialog-showing logic should not depend on the presence or absence of a Local State file. This change affects some POSIX platforms running Google Chrome for the first time. This logic being removed was originally added here: https://chromiumcodereview.appspot.com/14946003/. Bug: 1221483
mkarolin
added a commit
that referenced
this pull request
Sep 13, 2021
This reverts commit 0b78f9e, reversing changes made to d260b6a. Reverting because upstream has fixed the first run regression via: https://chromium.googlesource.com/chromium/src.git/+/f9385e0d893916cbb16b477bdec127e56f9897da Cherry-picked into cr94 as https://chromium.googlesource.com/chromium/src/+/3f20e2edeb0adf78a6a9a6208e2e02ad3c7d8810 commit f9385e0d893916cbb16b477bdec127e56f9897da Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Aug 30 13:31:02 2021 +0000 Ignore Local State when deciding whether to show the first run dialog. The bug was caused by an experiment that causes Local State to be written to disk during startup (before the first-run-dialog-showing logic is reached) on some clients. Since Local State existed on some clients, the dialog was not shown. However, the first-run-dialog-showing logic should not depend on the presence or absence of a Local State file. This change affects some POSIX platforms running Google Chrome for the first time. This logic being removed was originally added here: https://chromiumcodereview.appspot.com/14946003/. Bug: 1221483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#17667
With https://bugs.chromium.org/p/chromium/issues/detail?id=1243221,
Local State file is created at the startup.
When, "Local State" file is already existed ShouldShowFirstRunDialog().
Due to this, dialog is launched ramdomly only when this file is not
stored in FS becfore calling ShouldShowFirstRunDialog().
Browser only tries to run this dialog when first_run::IsChromeFirstRun()
is true. Checking "Local State" file again is redundant. Removed this
checking.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
`npm run test brave_unit_tests -- --filter=BravePathsTest