This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Add incognito to the extension manifest and set to split mode #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More info about the manifest item here: |
|
Please open an issue for this PR, thanks. |
Fixes brave/brave-browser#1323 Matches the behavior of `browser-laptop` which you can see here: https://github.com/brave/browser-laptop/blob/41e46f9ce7e0d4f7a558646f377e40d29d0e101d/app/extensions.js#L36-L216 This should help in solving brave/brave-browser#1198 Auditors: @bridiver, @diracdeltas
|
@yrliou issue brave/brave-browser#1323 created; I amended the commit to include the closing keywords 😄 Ready for re-review/re-approval |
yrliou
approved these changes
Sep 27, 2018
bsclifton
added a commit
to brave/brave-core
that referenced
this pull request
Sep 28, 2018
…n#67 was merged Helps with addressing brave/brave-browser#1198
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches the behavior of
browser-laptopwhich you can see here:https://github.com/brave/browser-laptop/blob/41e46f9ce7e0d4f7a558646f377e40d29d0e101d/app/extensions.js#L36-L216
This should help in solving brave/brave-browser#1198
Auditors: @bridiver, @diracdeltas