Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Playlist] Play/Pause button is not updated when collapsing and reopening Brave #7459

Closed
hffvld opened this issue May 16, 2023 · 2 comments
Closed

Comments

@hffvld
Copy link
Collaborator

hffvld commented May 16, 2023

Description:

Play/Pause button is not updated when collapsing and reopening Brave

Steps to Reproduce

  1. Launch Brave > Go to music.youtube.com and add a song to a Playlist by tapping an icon on URL bar, for example
  2. Open settings > Make sure Enable Background Audio is OFF
  3. Open Playlist from the menu > Observe Pause button is shown
  4. Collapse Brave > Notice that music stopped playing
  5. Reopen Brave > Observe Pause button and no music playing

Actual result:

Pause button is shown instead of a Play button when music was playing and the user collapsed and then reopened Brave (Enable Background Audio is OFF).

Playlist_Play_Pause.mov

Expected result:

When Brave collapsed/reopened, Play button must be shown if Enable Background Audio is OFF

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.51 (23.5.15.14)
BraveCore: 1.51.114 (113.0.5672.92)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone 14 [iOS 16.4.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld hffvld changed the title Play/Pause button is not updated when collapsing and reopening Brave [Playlist] Play/Pause button is not updated when collapsing and reopening Brave May 18, 2023
@hffvld hffvld added the OS/iOS label Jun 29, 2023
@Brandon-T Brandon-T added this to the 1.62 milestone Dec 12, 2023
@Brandon-T
Copy link
Collaborator

This should already be fixed.

@hffvld
Copy link
Collaborator Author

hffvld commented Jan 11, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.2
Brave build: 1.62 (24.1.9.23)
BraveCore: 1.62.128 (120.0.6099.144)

STEPS:

  1. Follow the steps from [Playlist] Play/Pause button is not updated when collapsing and reopening Brave #7459 (comment)

ACTUAL RESULTS:

  • Verified that audio and video added to the playlist continue playing when hiding Brave or locking the phone
  • Verified that Play / Pause button is shown according to the audio/video file status

2024-01-10_16-29-52.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants