Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7403: Fix ServerTrust notification to update the URL bar #7420

Merged
merged 1 commit into from
May 9, 2023

Conversation

Brandon-T
Copy link
Collaborator

Summary of Changes

  • Server Trust does not post a notification if the trust itself hasn't changed. Problem is that the trust on NTP is the same as on an HTTP site. So visiting an HTTP site takes the same trust as on NTP, which is wrong. To fix this, we post a notification ourselves to let us know that the URL changed but the trust stayed the same.
    This in turn causes the revalidation to happen.

This pull request fixes #7403

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.51 milestone May 9, 2023
@Brandon-T Brandon-T self-assigned this May 9, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner May 9, 2023 16:49
@iccub iccub merged commit b456f7f into development May 9, 2023
@iccub iccub deleted the bugfix/ServerTrust branch May 9, 2023 19:09
iccub pushed a commit that referenced this pull request May 9, 2023
Server Trust does not post a notification if the trust itself hasn't changed. Problem is that the trust on NTP is the same as on an HTTP site. So visiting an HTTP site takes the same trust as on NTP, which is wrong. To fix this, we post a notification ourselves to let us know that the URL changed but the trust stayed the same.
This in turn causes the revalidation to happen.
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…URL bar (brave/brave-ios#7420)

Server Trust does not post a notification if the trust itself hasn't changed. Problem is that the trust on NTP is the same as on an HTTP site. So visiting an HTTP site takes the same trust as on NTP, which is wrong. To fix this, we post a notification ourselves to let us know that the URL changed but the trust stayed the same.
This in turn causes the revalidation to happen.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave incorrectly reports HTTP connection as secure (shows lock icon)
2 participants