Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #4879: VPN churn improvements - Popover Types #7670

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Ref #4879: VPN churn improvements - Popover Types #7670

merged 7 commits into from
Jul 24, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jun 30, 2023 •
edited
Loading

Summary of Changes

This pull request fixes #4879

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

N/A

Screenshots:

iOS Churn Promos: Auto-renew + iOS Churn Promos: payment issues

churn1

churn1 1 5

iOS Churn Promos: voluntary churned

WIP N/A

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel self-assigned this Jun 30, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/vpn-popover-churn branch from a1032d5 to ec00499 Compare July 5, 2023 20:31
@soner-yuksel soner-yuksel changed the title [WIP] Ref #4879: VPN churn improvements - Popover Types Ref #4879: VPN churn improvements - Popover Types Jul 7, 2023
@soner-yuksel soner-yuksel marked this pull request as ready for review July 7, 2023 22:06
@soner-yuksel soner-yuksel requested a review from a team as a code owner July 7, 2023 22:06
@soner-yuksel soner-yuksel force-pushed the enhancement/vpn-popover-churn branch from 171e7eb to 2602d2b Compare July 11, 2023 20:37
@soner-yuksel soner-yuksel requested a review from iccub July 11, 2023 20:41
@soner-yuksel soner-yuksel added this to the 1.57 milestone Jul 24, 2023
@soner-yuksel soner-yuksel merged commit 517c58d into development Jul 24, 2023
7 checks passed
@soner-yuksel soner-yuksel deleted the enhancement/vpn-popover-churn branch July 24, 2023 17:11
@soner-yuksel soner-yuksel mentioned this pull request Jul 28, 2023
Merged
11 tasks
@soner-yuksel soner-yuksel mentioned this pull request Sep 7, 2023
Merged
11 tasks
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@soner-yuksel
Ref brave/brave-ios#4879: VPN churn improvements - Popover Types (bra…
d879a30 
…ve/brave-ios#7670)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
enhancement
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.

VPN Billing Retry Changes
2 participants
@soner-yuksel @iccub