Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAT gating translations (#1167) #1174

Merged
merged 1 commit into from
Jul 25, 2023
Merged

BAT gating translations (#1167) #1174

merged 1 commit into from
Jul 25, 2023

Conversation

mrose17
Copy link
Member

@mrose17 mrose17 commented Jul 25, 2023

  1. Disable dependabot for normal dependency updates. Note the dependabot PRs will need to be manually closed, and the "security" dependabot PRs will continue.

  2. Use renovateapp instead.

The renovate configuration included here is based on that from ads-serve, and:

a. waits for updates to have been published for 4 days before raising a PR - this both reduces churn and also avoids the 3 day period where npm-published entries can be "unpublished" b. combines all minor and patch updates into a single PR


  1. Disable dependabot for normal dependency updates. Note the dependabot PRs will need to be manually closed, and the "security" dependabot PRs will continue.

  2. Use renovateapp instead.

The renovate configuration included here is based on that from ads-serve, and:

a. waits for updates to have been published for 4 days before raising a PR - this both reduces churn and also avoids the 3 day period where npm-published entries can be "unpublished" b. combines all minor and patch updates into a single PR


  • aesthetic changes

  • updating default gated value to 1 wei

  • adding type/enum safety and removing needless futureproofing, using translation rather than string literals

  • simple change for dev2 compat

  • fix error message + typo

  • adding error text for no BAT in BAT-gating

  • fixed some optional stuff

  • remove unsused prop in NonExpandablePanel

  • adding japanese translations


* first mockup on dev2

* remove cluttered talk, add request payload

* change permission name from BAT-gating to balance as per spec sheet

* Renovate/all minor patch (#1062)

* Use renovate for dependency updates (#1054)

1. Disable dependabot for normal dependency updates. Note the dependabot PRs will need to be manually closed, and the "security" dependabot PRs will continue.

2. Use renovateapp instead.

The renovate configuration included here is based on that from ads-serve, and:

a. waits for updates to have been published for 4 days before raising a PR - this both reduces churn and also avoids the 3 day period where npm-published entries can be "unpublished"
b. combines all minor and patch updates into a single PR

* removed as *[bot] is not accepted by AWS (#1055)

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>

* Update all non-major dependencies

---------

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: Graham Tackley <gtackley@brave.com>
Co-authored-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Renovate/node 18.x (#1068)

* Use renovate for dependency updates (#1054)

1. Disable dependabot for normal dependency updates. Note the dependabot PRs will need to be manually closed, and the "security" dependabot PRs will continue.

2. Use renovateapp instead.

The renovate configuration included here is based on that from ads-serve, and:

a. waits for updates to have been published for 4 days before raising a PR - this both reduces churn and also avoids the 3 day period where npm-published entries can be "unpublished"
b. combines all minor and patch updates into a single PR

* removed as *[bot] is not accepted by AWS (#1055)

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>

* Update all non-major dependencies (#1057)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Pin dependencies (#1056)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update all non-major dependencies (#1063)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Node.js to v18.16.1

---------

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: Graham Tackley <gtackley@brave.com>
Co-authored-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* aesthetic changes

* updating default gated value to 1 wei

* adding type/enum safety and removing needless futureproofing, using translation rather than string literals

* simple change for dev2 compat

* fix error message + typo

* adding error text for no BAT in BAT-gating

* fixed some optional stuff

* remove unsused prop in NonExpandablePanel

* adding japanese translations

---------

Signed-off-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: David Suh <davidsuh@Davids-MacBook-Pro.local>
Co-authored-by: Marshall T. Rose <mrose17@gmail.com>
Co-authored-by: Graham Tackley <gtackley@brave.com>
Co-authored-by: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@mrose17 mrose17 merged commit 1809c5e into dev3 Jul 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants