Added unit tests

brave · Mar 3, 2017 · 04878a9 · 04878a9
1 parent 14f8d7d
commit 04878a9
Show file tree

Hide file tree

Showing 4 changed files with 52 additions and 4 deletions.
diff --git a/app/renderer/components/settings.js b/app/renderer/components/settings.js
@@ -124,15 +124,15 @@ class SettingItemIcon extends ImmutableComponent {
       <div>
         {
           this.props.position === 'left'
-            ? <span className={css(bg.Icon, styles.icon, styles.iconLeft)} onClick={this.props.clickAction} />
+            ? <span className={css(bg.Icon, styles.icon, styles.iconLeft)} data-icon-position='left' onClick={this.props.clickAction} />
             : null
         }
         <div className={css(styles.child)}>
           {this.props.children}
         </div>
         {
           this.props.position === 'right'
-            ? <span className={css(bg.Icon, styles.icon, styles.iconRight)} onClick={this.props.clickAction} />
+            ? <span className={css(bg.Icon, styles.icon, styles.iconRight)} data-icon-position='right' onClick={this.props.clickAction} />
             : null
         }
       </div>

diff --git a/test/unit/about/preferencesTest.js b/test/unit/about/preferencesTest.js
@@ -8,7 +8,7 @@ const {mount} = require('enzyme')
 const sinon = require('sinon')
 const assert = require('assert')
 const fakeElectron = require('../lib/fakeElectron')
-let Preferences
+let Preferences, aboutActions, SettingItemIcon
 require('../braveUnit')
 
 describe('Preferences component', function () {
@@ -38,6 +38,8 @@ describe('Preferences component', function () {
     window.CustomEvent = {}
 
     Preferences = require('../../../js/about/preferences').AboutPreferences
+    SettingItemIcon = require('../../../app/renderer/components/settings').SettingItemIcon
+    aboutActions = require('../../../js/about/aboutActions')
   })
   after(function () {
     mockery.disable()
@@ -77,4 +79,21 @@ describe('Preferences component', function () {
       assert.equal(this.result.find('[data-l10n-id="searchSettings"]').length, 1)
     })
   })
+
+  describe('General', function () {
+    describe('Default path', function () {
+      it('call aboutActions.defaultDownloadPath when pencil is clicked', function () {
+        const spy = sinon.spy(aboutActions, 'defaultDownloadPath')
+        const wrapper = mount(
+          <SettingItemIcon
+            clickAction={aboutActions.defaultDownloadPath()}
+            position='right'
+          />
+        )
+        wrapper.find('span[data-icon-position="right"]').simulate('click')
+        assert.equal(spy.calledOnce, true)
+        aboutActions.defaultDownloadPath.restore()
+      })
+    })
+  })
 })
diff --git a/test/unit/app/browser/reducers/downloadsReducerTest.js b/test/unit/app/browser/reducers/downloadsReducerTest.js
@@ -231,4 +231,29 @@ describe('downloadsReducer', function () {
       })
     })
   })
+
+  describe('APP_DOWNLOAD_DEFAULT_PATH', function () {
+    let stub
+
+    after(function () {
+      stub.restore()
+    })
+
+    it('Opens a folder selection dialog', function () {
+      stub = sinon.stub(fakeElectron.dialog, 'showOpenDialog')
+      downloadsReducer({}, {actionType: appConstants.APP_DOWNLOAD_DEFAULT_PATH})
+      assert(stub.calledOnce)
+      stub.restore()
+    })
+
+    it('Opens a folder selection with correct params', function (cb) {
+      stub = sinon.stub(fakeElectron.dialog, 'showOpenDialog', function (window, options) {
+        assert.equal(options.defaultPath, `${process.cwd()}/downloads`)
+        assert.deepEqual(options.properties, ['openDirectory'])
+        cb()
+      })
+
+      downloadsReducer({}, {actionType: appConstants.APP_DOWNLOAD_DEFAULT_PATH})
+    })
+  })
 })
diff --git a/test/unit/lib/fakeElectron.js b/test/unit/lib/fakeElectron.js
@@ -27,12 +27,16 @@ const fakeElectron = {
   },
   app: {
     on: function () {
-    }
+    },
+    getPath: (param) => `${process.cwd()}/${param}`
   },
   clipboard: {
     writeText: function () {
     }
   },
+  dialog: {
+    showOpenDialog: function () { }
+  },
   shell: {
     showItemInFolder: function () {
     },