Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Merge pull request #4400 from JohnONolan/visual-refinements
Browse files Browse the repository at this point in the history
Minor toolbar visual refinement suggestions
  • Loading branch information
bbondy authored Oct 4, 2016
2 parents 17b083c + aaea6c1 commit 0c6cbab
Show file tree
Hide file tree
Showing 6 changed files with 29 additions and 22 deletions.
10 changes: 5 additions & 5 deletions less/button.less
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ span.browserButton,
.browserButton {
cursor: default;
display: inline-block;
line-height: 30px;
width: 30px;
height: 28px;
font-size: 16px;
line-height: 25px;
width: 25px;
height: 25px;
font-size: 15px;
color: @buttonColor;
border-radius: @borderRadius;
margin: 0 3px;
Expand Down Expand Up @@ -57,7 +57,7 @@ span.browserButton,
width: 24px;
height: 100%;
opacity: 0.5;
background: url('../img/icon_new_frame.svg') 0 0 / contain no-repeat;
background: url('../img/icon_new_frame.svg') 50% 20% scroll / 20px no-repeat;
&:hover {
opacity: 0.8;
}
Expand Down
5 changes: 5 additions & 0 deletions less/contextMenu.less
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@
&:hover {
background-color: lighten(@menuSelectionColor, 5%);
color: white;

.accelerator,
.submenuIndicator {
color: #fff;
}
}
}
}
Expand Down
26 changes: 14 additions & 12 deletions less/navigationBar.less
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@
-webkit-app-region: no-drag;
-webkit-user-select: none;
color: @buttonColor;
border-radius: 50%;
border-radius: 4px;
font-weight: 300;
opacity: 0.2;

Expand All @@ -600,7 +600,7 @@

.back,
.forward {
font-size: 35px;
font-size: 25px;
text-align: center;
}
}
Expand All @@ -610,7 +610,7 @@
width: 0; // Fixes #4298
align-items: center;
justify-content: center;
height: 24px;
height: 25px;
padding: 0 10px;

display: flex;
Expand All @@ -626,9 +626,9 @@
content: ' ';
position: absolute;
background: #fff;
border: 2px solid @focusUrlbarOutline;
border: 1px solid @focusUrlbarOutline;
border-radius: 4px;
box-shadow: 0 0 1px @focusUrlbarOutline, inset 0 0 2px @focusUrlbarOutline, inset 0 1px 8px rgba(0, 137, 255, 0.5);
box-shadow: 0 0 1px @focusUrlbarOutline, inset 0 0 2px @focusUrlbarOutline, inset 0 1px 8px rgba(0, 137, 255, 0.1);
color: #333;
outline: none;
top: 0;
Expand All @@ -641,7 +641,7 @@
#navigator:not(.titleMode) & {
background: white;
border-radius: @borderRadiusURL;
box-shadow: inset 0 1px 1px rgba(0,0,0,0.3);
box-shadow: inset 0 0 0 1px rgba(0,0,0,0.1), inset 0 1px 0 rgba(0,0,0,0.05), inset 0 1px 1px rgba(0,0,0,0.1);
color: @chromeText;
}
@media (max-width: @breakpointNarrowViewport) {
Expand Down Expand Up @@ -686,11 +686,15 @@
display: inline-block;
background:rgba(243, 243, 243, 0);
color: @chromeText;
font-size: 15px;
font-size: 13px;
max-width: 100%;
overflow-x: hidden;
text-overflow: ellipsis;
white-space: nowrap;

strong {
font-weight: 600;
}
}

.endButtons {
Expand All @@ -706,7 +710,7 @@

&[class*=" fa-"] {
margin-right: 5px;
margin-top: 3px;
margin-top: 1px;
font-size: 14px;
min-height: 12px;
color: @chromeText;
Expand Down Expand Up @@ -781,7 +785,7 @@
cursor: text;
font-size: @defaultFontSize;
font-weight: normal;
margin: 3px 0 0 3px;
margin: 2px 0 0 3px;
outline: none;
text-overflow: ellipsis;
flex-grow: 1;
Expand Down Expand Up @@ -835,7 +839,5 @@
url(../app/extensions/brave/img/braveBtn2x.png) 2x,
url(../app/extensions/brave/img/braveBtn3x.png) 3x);
background-repeat: no-repeat;
height: 27px;
margin-top: 3px;
height: 24px;
}

2 changes: 1 addition & 1 deletion less/tabs.less
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@
padding-right: 2px;
.browserButton {
display: inline-block;
line-height: 21px;
line-height: 20px;
}
}

Expand Down
6 changes: 3 additions & 3 deletions less/variables.less
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@chromeTertiary: #c7c7c7;
@chromeText: #555555;

@tabsBackground: #ccc;
@tabsBackground: #dcdcdc;
@navigationBarBackground: @chromeSecondary;
@navigationBarBackground: white;
@chromeBorderColor: @chromePrimary;
Expand Down Expand Up @@ -71,10 +71,10 @@
@bookmarksFolderIconSize: 15px;

@navbarButtonSpacing: 4px;
@navbarButtonWidth: 35px;
@navbarButtonWidth: 21px;
@navbarBraveButtonWidth: 23px;
@navbarBraveButtonMarginLeft: 80px;
@navbarLeftMarginDarwin: 70px;
@navbarLeftMarginDarwin: 76px;

@findbarBackground: #F7F7F7;

Expand Down
2 changes: 1 addition & 1 deletion less/window.less
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}
}
:root {
--default-font-family: "Arial";
--default-font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
}

* {
Expand Down

0 comments on commit 0c6cbab

Please sign in to comment.