Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Show 0 USD instead of 0 BTC before wallet creation
Browse files Browse the repository at this point in the history 
Auditors: @bradleyrichter
  • Loading branch information
@diracdeltas
diracdeltas committed Aug 29, 2016
1 parent af4e7df commit 22ab1bf
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions js/about/preferences.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -650,10 +650,7 @@ class PaymentsTab extends ImmutableComponent {

btcToCurrencyString (btc) {
const balance = Number(btc || 0)
const currency = this.props.ledgerData.get('currency')
if (!currency) {
return `${balance} BTC`
}
const currency = this.props.ledgerData.get('currency') || 'USD'
if (balance === 0) {
return `0 ${currency}`
}
Expand Down

3 comments on commit 22ab1bf

@bradleyrichter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could be more fancy with the output:

image

0 USD feels too blunt to me.

Are we able to display all of the currency characters without too much trouble?

@bradleyrichter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The USD fits/feels fine in the monthly budget menu...

It's redundant except for the few countries that also use dollars that aren't USD.

@diracdeltas
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's an open issue #3533

Please sign in to comment.