Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Ensure list has a value set before calling push (in FrameStateUtil).
Browse files Browse the repository at this point in the history
This was causing a crash which breaks the browser window.
I believe this issue is related to the issues we have where wrong index is picked after closing / tearing off tab

Auditors: @NejcZdovc, @bbondy
  • Loading branch information
bsclifton committed Aug 28, 2017
1 parent 921c203 commit 29b8e48
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/state/frameStateUtil.js
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ function addFrame (state, frameOpts, newKey, partitionNumber, openInForeground,
*/
function removeFrame (state, frameProps, framePropsIndex) {
const frames = state.get('frames')
let closedFrames = state.get('closedFrames')
let closedFrames = state.get('closedFrames') || Immutable.List()
const newFrames = frames.splice(framePropsIndex, 1)

if (isValidClosedFrame(frameProps)) {
Expand Down

0 comments on commit 29b8e48

Please sign in to comment.