Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Revert "Handle query values as objects for cached parsed urls"
Browse files Browse the repository at this point in the history
This reverts commit 065b51a.
  • Loading branch information
diracdeltas committed Jun 15, 2017
1 parent d329334 commit 77873c3
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions app/common/lib/siteSuggestions.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,6 @@ const tokenizeInput = (data) => {
parts = parts.concat(parsedUrl.pathname.split(/[.\s\\/]/))
}
if (parsedUrl.query) {
// I think fast-url-parser has a bug in it where it returns an object for query
// instead of a string. Object is supported but only when you pass in true
// for the second value of parse which we don't do.
// We can remove this when we change away from using fast-url-parser in favour of the
// Chrome URL parser.
if (parsedUrl.query.constructor !== String) {
parsedUrl.query = Object.entries(parsedUrl.query).map((x) => x.join('=')).join('&')
}
parts = parts.concat(parsedUrl.query.split(/[&=]/))
}
if (parsedUrl.protocol) {
Expand Down

2 comments on commit 77873c3

@bbondy
Copy link
Member

@bbondy bbondy commented on 77873c3 Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this reverted? Is there an issue I can read to learn more?

@srirambv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9500 Original issue for which this was reverted

Please sign in to comment.