Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Add new "automatically send usage stats" setting under advanced setti…
Browse files Browse the repository at this point in the history
…ngs.

By default, it's set to false; folks can opt-in by enabling it.

Fixes #4691

Auditors: @aekeus @bradleyrichter

Test Plan:
1. Open Brave and launch preferences
2. Go under advanced and see new setting (set to false)
3. Set to true and quit Brave
4. Relaunch Brave and open preferences > advanced
5. Setting should be persisted
  • Loading branch information
bsclifton committed Oct 17, 2016
1 parent b949a84 commit 7c43018
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/extensions/brave/locales/en-US/preferences.properties
Original file line number Diff line number Diff line change
Expand Up @@ -245,4 +245,5 @@ enableAutofill=Enable Autofill
importBrowserData=Import Browser Data
importNow=Import now…
clearAll=Clear all
sendCrashReports=Send anonymous crash reports to Brave (requires browser restart)
sendCrashReports=Send anonymous crash reports to Brave (requires browser restart)
sendUsageStatistics=Automatically send usage statistics to Brave
1 change: 1 addition & 0 deletions js/about/preferences.js
Original file line number Diff line number Diff line change
Expand Up @@ -1501,6 +1501,7 @@ class AdvancedTab extends ImmutableComponent {
<SettingCheckbox dataL10nId='usePDFJS' prefKey={settings.PDFJS_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='useSmoothScroll' prefKey={settings.SMOOTH_SCROLL_ENABLED} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='sendCrashReports' prefKey={settings.SEND_CRASH_REPORTS} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
<SettingCheckbox dataL10nId='sendUsageStatistics' prefKey={settings.SEND_USAGE_STATISTICS} settings={this.props.settings} onChangeSetting={this.props.onChangeSetting} />
</SettingsList>
</div>
}
Expand Down
1 change: 1 addition & 0 deletions js/constants/appConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ module.exports = {
'advanced.pdfjs-enabled': true,
'advanced.smooth-scroll-enabled': false,
'advanced.send-crash-reports': true,
'advanced.send-usage-statistics': false,
'advanced.minimum-visit-time': 8,
'advanced.minimum-visits': 5,
'shutdown.clear-history': false,
Expand Down
1 change: 1 addition & 0 deletions js/constants/settings.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ const settings = {
DEFAULT_ZOOM_LEVEL: 'advanced.default-zoom-level',
SMOOTH_SCROLL_ENABLED: 'advanced.smooth-scroll-enabled',
SEND_CRASH_REPORTS: 'advanced.send-crash-reports',
SEND_USAGE_STATISTICS: 'advanced.send-usage-statistics',
ADBLOCK_CUSTOM_RULES: 'adblock.customRules',
MINIMUM_VISIT_TIME: 'advanced.minimum-visit-time',
MINIMUM_VISTS: 'advanced.minimum-visits'
Expand Down

0 comments on commit 7c43018

Please sign in to comment.