Blocked count should not update for background tabs

Fix #11400 Auditors: @bsclifton
brave · Oct 11, 2017 · c0aea8f · c0aea8f
1 parent 987d664
commit c0aea8f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/app/renderer/components/main/main.js b/app/renderer/components/main/main.js
@@ -382,7 +382,7 @@ class Main extends React.Component {
     })
 
     ipc.on(messages.BLOCKED_RESOURCE, (e, blockType, details) => {
-      windowActions.setBlockedBy(this.props.tabId, blockType, details.url)
+      windowActions.setBlockedBy(details.tabId, blockType, details.url)
     })
 
     ipc.on(messages.HTTPSE_RULE_APPLIED, (e, ruleset, details) => {

diff --git a/test/bravery-components/braveryPanelTest.js b/test/bravery-components/braveryPanelTest.js
@@ -58,6 +58,19 @@ describe('Bravery Panel', function () {
         .windowByUrl(Brave.browserWindowUrl)
         .waitForTextValue('[data-test-id="lionBadge"]', '2')
     })
+    it('lion badge does not update for background loads', function * () {
+      const url = Brave.server.url('tracking.html')
+      yield this.app.client
+        .waitForDataFile('trackingProtection')
+        .newTab({ url })
+        .waitForTabCount(2)
+        .windowByUrl(Brave.browserWindowUrl)
+        .newTab({ url })
+        .waitForTabCount(3)
+        .windowByUrl(Brave.browserWindowUrl)
+        .ipcSend('blocked-resource', 'adblock', { url, tabId: 5 })
+        .waitForTextValue('[data-test-id="lionBadge"]', '2')
+    })
   })
   describe('Tracking Protection stats', function () {
     Brave.beforeEach(this)