Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Replace 'Hide lower' button's label with something else #10158

Closed
luixxiul opened this issue Jul 26, 2017 · 0 comments
Closed

Replace 'Hide lower' button's label with something else #10158

luixxiul opened this issue Jul 26, 2017 · 0 comments
Assignees
@luixxiul
Labels
copy/content/text feature/about-pages feature/rewards l10n polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jul 26, 2017 •
edited
Loading

Test plan

#10164 (comment)

Describe the issue you encountered:
Replace 'Hide lower' button's label with something else.

browser-laptop/app/extensions/brave/locales/en-US/preferences.properties

Line 375 in d14fb50

hideLower=Hide lower
.

It is not obvious what lower means here (lower than what?).

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Run npm run add-simulated-synopsis-visits 100
    2. Click show all

  • Actual result: the label of the button displayed bottom is Hide Lower

  • Expected result: the label should be replaced with something clearer. eg. Hide small contribution sites, Hide low contribution sites, etc.

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: Add "Hide Lower" button on Brave Payments #9137
@luixxiul luixxiul added copy/content/text feature/about-pages feature/rewards l10n polish Nice to have — usually related to front-end/visual tasks. labels Jul 26, 2017
@luixxiul luixxiul added this to the 0.21.x milestone Jul 26, 2017
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
@luixxiul luixxiul self-assigned this Jul 27, 2017
@luixxiul luixxiul mentioned this issue Jul 27, 2017
Merged
8 tasks
@luixxiul luixxiul modified the milestones: 0.20.x (Nightly Channel), 0.21.x Jul 27, 2017
@luixxiul luixxiul modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 6, 2017
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@dfperry5
Replace hideLower with showLess
821998d 
Also:
- Rename constants to sort them not only alphabetically but semantically
- Add lacking states to docs/state.md

Closes brave#10158

Auditors:

Test Plan:
1. Run `npm run add-simulated-synopsis-visits 100`
2. Open about:preferences#payments
3. Click `Show All` button
4. Click `Show Less` button
5. Make sure the buttons work
@bsclifton bsclifton modified the milestones: 0.21.x (Nightly Channel), 0.19.x (Beta Channel) Oct 4, 2017
This was referenced Oct 9, 2017
Closed
Closed
This was referenced Oct 12, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
copy/content/text feature/about-pages feature/rewards l10n polish Nice to have — usually related to front-end/visual tasks. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@luixxiul @bsclifton @srirambv @LaurenWags