Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Use better name mappings for channels on about:brave #10239

Closed
bbondy opened this issue Aug 1, 2017 · 9 comments
Closed

Use better name mappings for channels on about:brave #10239

bbondy opened this issue Aug 1, 2017 · 9 comments

Comments

@bbondy
Copy link
Member

bbondy commented Aug 1, 2017

Test plan

  1. Visit about:brave using a production release
  2. Channel should say Release
  3. Visit about:brave using a beta release
  4. Channel should say Beta
  5. If translations are available, try the above steps after changing language

Original issue description

We should map the following identifiers in about:brave to the real channel name:

This will avoid people using the confusing internal names to refer to the channels.

dev -> Release
beta -> Beta
developer -> Developer
nightly -> Nightly

@bbondy bbondy added this to the 0.18.x Hotfix milestone Aug 1, 2017
@bsclifton
Copy link
Member

@baoqchau would you be interested in this one? It would be pretty similar to the fix you did with #10047

We just need a mapping between the channel (ex: dev) and the human readable name (ex: Release) 😄

@prasanthp96
Copy link
Contributor

hello @bsclifton! I am interested to work on this bug, if it is not taken yet, can I fix it ?

@baoqchau
Copy link
Contributor

baoqchau commented Aug 5, 2017

@prasanthp96 Go ahead. I am a little busy these days so I cannot take on this issue.

@bsclifton
Copy link
Member

@prasanthp96 that would be great! 😄 Please do work on it (I'll reserve it for you by assigning myself). Let me know if you have any questions 😄

@bsclifton bsclifton self-assigned this Aug 5, 2017
@bsclifton
Copy link
Member

@prasanthp96 have you had a chance to check this one out yet? Let me know how it's going 😄

@prasanthp96
Copy link
Contributor

Hy @bsclifton , sorry for the delay, I will start working on this today.

@bsclifton bsclifton modified the milestones: 0.19.x (Beta Channel), 0.18.x Hotfix Aug 9, 2017
@prasanthp96
Copy link
Contributor

@bsclifton I could see only three channels listed in https://github.com/brave/browser-laptop/blob/master/app/channel.js. Will it suffice changing these alone ? or should I alter any other code?

@bsclifton
Copy link
Member

@prasanthp96 I'd say let's move forward with just dev and beta for now 😄 We will be adding support for the other two very soon and stable isn't used (we can ignore it for now).

Once you have the mapping in place, it should be easy to adjust once we have the new channels (developer, nightly) added 😄

@prasanthp96
Copy link
Contributor

@bsclifton I have sent an PR, have a look!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.