This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Paused download shows Infinity% #10264
Assignees
Labels
Milestone
Comments
srirambv
added
feature/download
polish
luixxiul
added
bug
and removed
polish
diracdeltas
added a commit
that referenced
this issue
Aug 24, 2017
8 tasks
bsclifton
pushed a commit
that referenced
this issue
Sep 9, 2017
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 10, 2017
When a user downloads a file to a location that they do not have access to, it currently just says "Downloading... 0%". This is to add a download state to indicate that the user doesn't have access to the director they are trying to download into. Commit list: - Add new download state - Update state if directory is unauthorized - Update electron download state change - Add 'Unauthorized' download state to 'clear completed downloads' reducer - Add isUnauthorized getter - Add unauthorized state as part of condition for hiding progress display - Add isUnauthorized to condition for rendering a download item - Set unauthorized as a stop condition for downloads - Set getL10nId for unauthorized downloads - Add 'unauthorized' as a style class for finished download items - Add downloadUnauthorized locale id for all languages TODO: Update localization for all languages for this state Fixes brave#7747 Update test Return 0% when download totalBytes is 0 or undefined Fix brave#10264 Updated code to handle falsey inputs + added more unit tests :) Auditors: @diracdeltas Test Plan: `npm run unittest -- --grep="downloadUtil"` Move properties inside main.less to window.less Closes brave#10860 Auditors: Test Plan: 1. npm run watch 2. npm start 3. Make sure the browser starts 4. Open the devtool and make sure the two properties are applied Converted Country Textbox to Select Dropdown Creating a dropdown for the country list in the about:autofill panel Fix brave#9053 Small cleanup for autofill country list per discussion in PR Auditors: @dfperry5 Fix two issues - handle when locale is called with null/undefined/falsey value (before would fail on toLowerCase()) - handle situation where activeTab is not set and developer tools are opened (will be fixed soon by @bbondy) Auditors: @bbondy, @dfperry5 Issue brave#9053 - Updating so that first option on dropdown for countries is a blank modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js modified: app/renderer/components/autofill/autofillAddressPanel.js Add 'CommonFormFullWidthDropdown' to commonForm.js Auditors: @cezaraugusto Test Plan: 1. Open about:autofill 2. Click 'Add Address' Update autofill webdriver tests to use Country as a dropdown value instead of a text field Auditors: @dfperry5, @darkdh, @luixxiul Test Plan: `npm run test -- --grep="Autofill" Style Edits Auditors: Test Plan:
This was referenced Dec 20, 2017
This was referenced Dec 27, 2017
31 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#10652 (comment)
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Paused download from Google Drive shows as
Paused: Infinity%Platform (Win7, 8, 10? macOS? Linux distro?):
Windows 10 x64
Brave Version (revision SHA):
Steps to reproduce:
Paused: Infinity%Actual result:
See screenshot
Expected result:
Should just show paused when download percentage is not calculated
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:
Any related issues:
cc: @NejcZdovc @bsclifton
The text was updated successfully, but these errors were encountered: