Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hide bitwarden and pinterest for 0.18.x #10343

Closed
alexwykoff opened this issue Aug 8, 2017 · 5 comments · Fixed by #10416
Closed

Hide bitwarden and pinterest for 0.18.x #10343

alexwykoff opened this issue Aug 8, 2017 · 5 comments · Fixed by #10416
Assignees
@bsclifton
Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.18.23 Hotfix

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Aug 8, 2017 •
edited by bsclifton
Loading

Test plan

  1. Open Preferences > Security and verify that bitwarden is not shown in the drop down under "Passwords and forms"
  2. Visit Preferences > Extensions and verify that bitwarden and Pinterest do not show

Original issue description

Mea culpa. QA should have spent more time on this before we made it visible.

We'll be focused on having it fixed in the near future.
@alexwykoff alexwykoff added this to the 0.18.x Hotfix milestone Aug 8, 2017
@bsclifton bsclifton changed the title Hide bitwarden for 0.18.x Hide bitwarden and pinterest for 0.18.x Aug 8, 2017
@bsclifton
Copy link
Member

Updated to call out hiding pinterest as well, until it's ready

cc: @jonathansampson @kevinlawler

@bsclifton bsclifton mentioned this issue Aug 8, 2017
Merged
8 tasks
@bsclifton
Copy link
Member

Fixed with #10345 (merged into all branches, including master)

This was referenced Aug 9, 2017
Closed
Closed
Closed
Closed
This was referenced Aug 10, 2017
Closed
Closed
@LaurenWags
Copy link
Member

On MacOS Bitwarden and Pinterest are hidden in a clean profile, but if they were previously enabled on 0.18.14 (released version), they are still visible under about:preferences#extensions and beside the URL bar.

10343

@LaurenWags LaurenWags reopened this Aug 10, 2017
@bsclifton
Copy link
Member

Great find, @LaurenWags 😄 I've got a fix here, will submit a PR shortly

@bsclifton bsclifton mentioned this issue Aug 10, 2017
Merged
8 tasks
This was referenced Aug 11, 2017
Closed
Closed
@LaurenWags
Copy link
Member

Verified using update from 0.18.14 where they were enabled and on 0.18.22 using clean profile.

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@bsclifton @dfperry5
Hide unsupported extensions
bd3f7de 
Fixes brave#10343

Auditors: @bbondy, @jonathansampson
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/extensions QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.18.23 Hotfix
Development

Successfully merging a pull request may close this issue.

Hide unsupported extensions
5 participants
@alexwykoff @luixxiul @bsclifton @srirambv @LaurenWags