Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Block Scripts from Bravery Icon #10408

Closed
LaurenWags opened this issue Aug 10, 2017 · 0 comments · Fixed by #10407
Closed

Block Scripts from Bravery Icon #10408

LaurenWags opened this issue Aug 10, 2017 · 0 comments · Fixed by #10407

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 10, 2017

Test plan

#10407 (comment)


  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    If you enable 'Block Scripts' from the Bravery icon, scripts are blocked, but the toggle still shows off. You are unable to 'undo' this action from Bravery icon.
    Additionally, if you have 'Block Scripts' enabled by default, you can click on it to unblock scripts from the Bravery Icon, but the toggle still shows on.
    This was working in 0.18.20

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    Brave | 0.18.21
    rev | 263b6d5
    Muon | 4.3.9

  • Steps to reproduce:

    1. Clean install of 0.18.21
    2. Open tab and navigate to brianbondy.com.
    3. Click on shields.
    4. Select toggle for Block Scripts.
    5. Content on brianbondy.com is not loaded, but toggle still displays as off (gray, not orange).
    6. Additionally if you close shields, you cannot allow script from the URL bar.
  • Actual result:
    Toggle displays off, you cannot undo the action from the shields.

  • Expected result:
    Toggle should display on, and you should be able to undo your selection.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    No

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    blockscripts

  • Any related issues:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.