This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Fix getOrigin to work with muon.url.parse #10407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #10391 Test Plan: 1. go to google.com 2. click 'remember this decision' and 'deny' when it asks for your location 3. close tab, open google.com again. it should not ask to see your location.
bbondy
approved these changes
Aug 10, 2017
diracdeltas
pushed a commit
that referenced
this pull request
Aug 10, 2017
Fix getOrigin to work with muon.url.parse
diracdeltas
pushed a commit
that referenced
this pull request
Aug 10, 2017
Fix getOrigin to work with muon.url.parse
Codecov Report
@@ Coverage Diff @@
## master #10407 +/- ##
==========================================
+ Coverage 53.8% 53.81% +<.01%
==========================================
Files 238 238
Lines 21051 21054 +3
Branches 3257 3258 +1
==========================================
+ Hits 11327 11330 +3
Misses 9724 9724
|
diracdeltas
pushed a commit
that referenced
this pull request
Aug 10, 2017
Fix getOrigin to work with muon.url.parse
bridiver
reviewed
Aug 10, 2017
| @@ -429,11 +429,14 @@ const UrlUtil = { | |||
| } | |||
|
|
|||
| let parsed = urlParse(location) | |||
| if (parsed.origin) { | |||
There was a problem hiding this comment.
I think at some point in the near future we should convert to chromium urls with a trailing /. Removing them for backwards compat is sure to create problems in the long-term
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10391
Fix #10408
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests