Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove LESS files from styles.js #10459

Closed
luixxiul opened this issue Aug 13, 2017 · 1 comment
Closed

Remove LESS files from styles.js #10459

luixxiul opened this issue Aug 13, 2017 · 1 comment
Assignees
@luixxiul
Labels
feature/about-pages QA/no-qa-needed release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 13, 2017 •
edited
Loading

Describe the issue you encountered: Remove LESS files from js/about/styles.js to make it possible to confirm how components should look by default.

There are some cases where components' styles are overridden by specifications on LESS files (such as preferences.less). It makes hard to find what should be converted, replaced and refactored if necessary. Removing the LESS files from that file will also help us to detect visual regressions and fix them if any.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Extra QA steps:

    1. Open about:styles

  • Any related issues:
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 13, 2017
@luixxiul luixxiul self-assigned this Aug 13, 2017
@luixxiul luixxiul mentioned this issue Aug 13, 2017
Merged
8 tasks
@luixxiul
Copy link
Contributor Author

Added the QA/no-qa-needed label as this one is covered by the manual test.

dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@dfperry5
Remove LESS files from styles.js
c52a62d 
Closes brave#10459

Auditors: @cezaraugusto

Test Plan:
1. Open about:styles
2. Make sure the page is rendered (you do not have to search for regressions)
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
2 participants
@bbondy @luixxiul