Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

siteInfo dialog cannot get large #10930

Closed
luixxiul opened this issue Sep 13, 2017 · 1 comment
Closed

siteInfo dialog cannot get large #10930

luixxiul opened this issue Sep 13, 2017 · 1 comment

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 13, 2017

Test plan

#10931 (comment)


Describe the issue you encountered: siteInfo dialog cannot get large.

This is a regression by 8f052cc#diff-2110fcba633a89ee7a534f4974f08975R254.

  • Platform (Win7, 8, 10? macOS? Linux distro?): All

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Open https://mixed-script.badssl.com/
    2. Click the lock icon
  • Actual result: the max-width of the dialog is 400px

    screenshot 2017-09-13 23 44 11
  • Expected result: it should be 500px

    screenshot 2017-09-14 0 12 30
  • Any related issues:

Setting the milestone to 0.19.x same as #9413.

@luixxiul
Copy link
Contributor Author

Added the release/blocking to this issue as this bug can cause a visual bug (button text overflowing) on other language settings.

@luixxiul luixxiul added the l10n label Sep 13, 2017
@luixxiul luixxiul self-assigned this Sep 13, 2017
NejcZdovc pushed a commit that referenced this issue Sep 13, 2017
Fixes #10930

Auditors:

Test Plan:
1. Open https://mixed-script.badssl.com/
2. Click the lock icon
3. Make sure the width of dialog is 500px
NejcZdovc pushed a commit that referenced this issue Sep 13, 2017
Fixes #10930

Auditors:

Test Plan:
1. Open https://mixed-script.badssl.com/
2. Click the lock icon
3. Make sure the width of dialog is 500px
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.