Top Site Tiles disappear after clicking on them

[LaurenWags]

Description

With a clean profile on 0.19.7, if you click on one of the top site tiles, after 5 seconds it is removed from the Dashboard.

Steps to Reproduce

1. Clean install of 0.19.7
2. Open up a new tab, click on one of the top site tiles.
3. Site is loaded in the tab.
4. Open a new tab.
5. If it took you less than 5s to open the new tab, your tile will be displayed and then it will disappear from view. If you took more than 5s to open the new tab, the tile will not be there at all.

Actual result:

Expected result:
Top site tile should not disappear after it is used.

Reproduces how often: 100%

Brave Version

Brave | 0.19.7
rev | c8481a9
Muon | 4.4.16

Additional Information

[LaurenWags]

this issue is not reproducible in 0.18.36:

[bbondy]

@LaurenWags is this still reproducible with 0.19.12 or later? I can't reproduce. It does change the icon with a similar affect but it doesn't remove the tile.

[srirambv]

It is still reproduced on 0.19.13

[LaurenWags]

@bbondy I am still reproducing in 0.19.13 but only if you click on those tiles with a clean profile:

If I have a profile that I've been using for a bit (like the profile I used for testing yesterday), clicking on the tiles does not make them disappear:

[bbondy]

Thanks for the confirmations.

I can reproduce on the release profile no problem.
I cannot reproduce on my dev profile with the same changeset.

Strange

[bbondy]

By profile above I meant config actually. Both are fresh profiles. Production builds cause the problem, development builds do not.

[bbondy]

Even stranger I reproduce when I build a production build locally with a fresh profile.

[bbondy]

Fixed:

0.19.x: 82d2eac
0.20.x: 12f516d
Fix does not apply to 0.21.x, but 0.21.x (currently master) has other issues which I posted for

[bsclifton]

@bbondy looks like you got bit by the wonderful Cmd + C bug 😄
0.19.x hash is 455742d