Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave wallet backup key overflows #11292

Closed
luixxiul opened this issue Oct 5, 2017 · 8 comments
Closed

Brave wallet backup key overflows #11292

luixxiul opened this issue Oct 5, 2017 · 8 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 5, 2017

Test plan

  1. Open about:preferences#payments
  2. Open advanced settings
  3. Click Backup your wallet
  4. Make sure the key does not overflow

Description

Because the key 2 will get longer, the key overflow the modal.

Steps to Reproduce

  1. Open about:preferences#payments
  2. Open advanced settings
  3. Click Backup your wallet

Actual result:

The key overflows

screenshot 2017-10-05 22 05 50

Expected result:

It should be wrapped

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

2ca8815

Reproducible on current live release:

Additional Information

@NejcZdovc
Copy link
Contributor

this is not the correct value. We shouldn't be changing css, but we have problem with keys

@NejcZdovc NejcZdovc self-assigned this Oct 5, 2017
@luixxiul luixxiul changed the title Brave wallet backup key 2 overflows Brave wallet backup key 2 has a wrong value Oct 5, 2017
@NejcZdovc
Copy link
Contributor

more info:

current master is working correctly (d6447e8), problem is only bat-integration branch. And that's because we changed the logic, how we are getting passphrase.

Master:

passphrase: parsedData.properties.wallet.keychains.passphrase,

BAT: https://github.com/brave/browser-laptop/pull/11231/files#diff-3cdfdb124f718787d584e9e2b82fcedcR1554

Problem is that logic changed in bat library.
ledger-client: https://github.com/brave/ledger-client/blob/master/index.js#L215
bat-client: https://github.com/brave-intl/bat-client/blob/master/index.js#L248

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 5, 2017

after talking with @mrose17 about it, this is new way of doing backup, so will fix css accordingly

@luixxiul luixxiul changed the title Brave wallet backup key 2 has a wrong value Brave wallet backup key 2 overflows Oct 5, 2017
@NejcZdovc
Copy link
Contributor

fixed with #11231

NejcZdovc added a commit that referenced this issue Oct 6, 2017
Resolves #9740
Resolves #10945
Resolves #11251 
Resolves #11264
Resolves #11285
Resolves #11289
Resolves #11292
Resolves #11293
@srirambv
Copy link
Collaborator

srirambv commented Oct 7, 2017

Added QA/checked as the workflow is changed to single key and this is obsolete

@luixxiul luixxiul changed the title Brave wallet backup key 2 overflows Brave wallet backup key overflows Oct 7, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 7, 2017

the single key should not overflow anyway.

@bsclifton
Copy link
Member

Removed milestone because this screen was reworked- this is no longer valid

@luixxiul
Copy link
Contributor Author

luixxiul commented Oct 9, 2017

This line of #11291 actually prevents the overflow.

https://github.com/brave/browser-laptop/blame/master/app/renderer/components/preferences/payment/ledgerBackup.js#L92

The hack with max-content which I have added will be removed with #11344 so no-qa-needed for this issue anyway.

@bsclifton bsclifton assigned luixxiul and unassigned NejcZdovc Oct 9, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
Resolves brave#9740
Resolves brave#10945
Resolves brave#11251 
Resolves brave#11264
Resolves brave#11285
Resolves brave#11289
Resolves brave#11292
Resolves brave#11293
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants