Clicking on pinned sites in Brave Payments removes them from the pinned list.

[jenn-rhim]

Description

[before clicking Stereokroma YT]

[after clicking]

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave Version

about:brave info:

0.19.116

Reproducible on current live release:

Additional Information

Mac 10.13.2

[NejcZdovc]

@jenn-rhim I tried to reproduce this, but without success. Can you please provide some more info?
OS, how to reproduce, which version, is this reproducible every time, etc?

[jenn-rhim]

I've added Brave vs and OS info above.

It is happening right now, consistently for me.

Go to the Preferences > Payments > click on a pinned site > return to Payments: the site you clicked gets removed from pinned list. It appears that the same phenomenon doesn't happen to the sites that are not pinned. -- I've tried this 5 sites each, pinned sites and unpinned sites.

[NejcZdovc]

hmm, that's really strange. Will ping you on slack and maybe we can do screen share and figure it out what's going on 😃

[NejcZdovc]

@jenn-rhim can you please try this with the latest beta version

[jenn-rhim]

@NejcZdovc yes, it is still happening on my browser. i just updated to 0.19.134. i had @alexwykoff sitting next to me to observe it. :)

[bsclifton]

Oh wow- this is really bad. It's happening to me... seems easy to reproduce. I've lost most of my ledger screen now because of this 😦

I think this might be the root cause for #12262 which @jenn-rhim also reported

[bsclifton]

@NejcZdovc this seems to be related to how there are two synopsis...

For the about page, we set the synopsis here:

browser-laptop/app/browser/tabs.js

Line 242 in 6dece0e

const migration = appState.get('migrations')

However, in ledgerState, it's setting a different location:

browser-laptop/app/common/state/ledgerState.js

Lines 96 to 107 in 6dece0e

	saveSynopsis: (state, publishers, options) => {
	state = validateState(state)
	if (options != null) {
	state = state.setIn(['ledger', 'synopsis', 'options'], makeImmutable(options))
	}
	if (publishers != null) {
	state = state.setIn(['ledger', 'synopsis', 'publishers'], makeImmutable(publishers))
	}
	return state
	},

I found a comment where you reference the duplicate entries:

browser-laptop/app/sessionStore.js

Lines 479 to 483 in 6dece0e

	const synopsisPaths = [
	// TODO (nejc) - remove duplicate entries in synopsis and about/synopsis
	['ledger', 'synopsis', 'publishers'],
	['ledger', 'about', 'synopsis']
	]

I suspect that clicking the entry is removing the entry from the 'ledger', 'about' synopsis by calling prune. I still have the value in my session store, but it's in the other location 'ledger', 'synopsis'

[NejcZdovc]

I don't have STR, but I have a profile on which I can reproduce it constantly.

[NejcZdovc]

Problem is in pageDataChanged as far as I can tell

[kjozwiak]

@bsclifton @NejcZdovc do we have any STR that we could use as a test plan?

[bsclifton]

Removing milestone; the issue (as described) was fixed with 0.20.x. With 0.20.30, the entries do not disappear when clicked. The underlying issue reported in 0.19.x (cache corruption after clicking entry) was fixed with #13103