Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Some entries (including pinned) disappear and then get re-added to ledger as unpinned #13102

Closed
bsclifton opened this issue Feb 12, 2018 · 4 comments
Closed

Some entries (including pinned) disappear and then get re-added to ledger as unpinned #13102

bsclifton opened this issue Feb 12, 2018 · 4 comments
Assignees
@NejcZdovc
Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include
Milestone
0.20.x Release 2 ...

Comments

@bsclifton
Copy link
Member

Description

This issue depends on the profile (it won't reproduce on a clean profile), but I am seeing entries disappear from Brave Payments and then get re-added. It seems that each visit removes/re-adds the entry. The sites which are affected are ones that disappeared after experiencing this bug:
#12274

Steps to Reproduce

  1. Have my profile
  2. Pin wikipedia.org
  3. Visit wikipedia.org

Actual result:

Synopsis information (time spent, # visits, etc) is lost and a new entry is created

Expected result:
The existing entry should accumulate and increment for additional visits

Reproduces how often:

100% of the time w/ my profile

Brave Version

about:brave info:

0.20.x

Reproducible on current live release:

Yes

Additional Information

Related: #12274
@bsclifton bsclifton added this to the 0.20.x Hotfix 2 (Referral Promotion) milestone Feb 12, 2018
@bsclifton
Copy link
Member Author

+1 via https://community.brave.com/t/pinned-brave-payments-getting-unpinned-automatically-macos-0-20-30/15772

@bsclifton
Copy link
Member Author

+1 via https://www.reddit.com/r/BATProject/comments/7wjf1b/psa_my_pinned_brave_payment_sites_have_been/

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 12, 2018
@NejcZdovc
Fixes disappearing publishers
d64291c 
Resolves brave#13102

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 12, 2018
Merged
10 tasks
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #13103 from NejcZdovc/hotfix/#13102-disappear
901e941 
Fixes disappearing publishers
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #13103 from NejcZdovc/hotfix/#13102-disappear
1b6323b 
Fixes disappearing publishers
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #13103 from NejcZdovc/hotfix/#13102-disappear
a7dac5c 
Fixes disappearing publishers
bsclifton added a commit that referenced this issue Feb 12, 2018
@bsclifton
Merge pull request #13103 from NejcZdovc/hotfix/#13102-disappear
9b983fb 
Fixes disappearing publishers
@kjozwiak
Copy link
Member

@bsclifton is this the same bug as #12274 as they share the same PR/Fix? Do they share the same STR/Test Plan?

@bsclifton bsclifton mentioned this issue Feb 14, 2018
Closed
@kjozwiak
Copy link
Member

While going through the above with @bsclifton, we also found #13134.

@kjozwiak kjozwiak mentioned this issue Feb 15, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 release-notes/include
Projects
None yet
Milestone
0.20.x Release 2 (Referral Promotion)
Development

No branches or pull requests
3 participants
@kjozwiak @bsclifton @NejcZdovc