Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Time between promotion checks should be semi-randomized #12355

Closed
evq opened this issue Dec 21, 2017 · 1 comment
Closed

Time between promotion checks should be semi-randomized #12355

evq opened this issue Dec 21, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/no-qa-needed QA/test-plan-specified release-notes/exclude security
Milestone
0.21.x (Release C...

Comments

@evq
Copy link
Member

evq commented Dec 21, 2017 •
edited by bsclifton
Loading

Test plan

See #12657

Original issue description

Currently the promotion check happens exactly every 24 hours. We should introduce a random component.
@evq evq changed the title Promotion check should be semi-randomized Time between promotion checks should be semi-randomized Dec 21, 2017
@NejcZdovc NejcZdovc self-assigned this Dec 21, 2017
@NejcZdovc NejcZdovc added this to the Triage Backlog milestone Jan 12, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 15, 2018
@NejcZdovc
Randomise promotions intervals
ea61c0d 
Resolves brave#12355

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 15, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 15, 2018
@NejcZdovc
Randomise promotions intervals
39126fc 
Resolves brave#12355

Auditors:

Test Plan:
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.20.x Hotfix 1 Jan 15, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 16, 2018
@NejcZdovc
Randomise promotions intervals
a95e859 
Resolves brave#12355

Auditors:

Test Plan:
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
bsclifton added a commit that referenced this issue Feb 8, 2018
@bsclifton
Merge pull request #12657 from NejcZdovc/hotfix/#12355-random
68b5444 
Randomise promotions intervals
bsclifton added a commit that referenced this issue Feb 8, 2018
@bsclifton
Merge pull request #12657 from NejcZdovc/hotfix/#12355-random
7257bbf 
Randomise promotions intervals
bsclifton added a commit that referenced this issue Feb 8, 2018
@bsclifton
Merge pull request #12657 from NejcZdovc/hotfix/#12355-random
e508df0 
Randomise promotions intervals
This was referenced Feb 20, 2018
Closed
Closed
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #12657 from NejcZdovc/hotfix/#12355-random
cd11167 
Randomise promotions intervals
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
This was referenced Feb 27, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Feb 27, 2018
Closed
@srirambv
Copy link
Collaborator

Per discussion with @NejcZdovc marking the issue as QA/no-qa-needed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/no-qa-needed QA/test-plan-specified release-notes/exclude security
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
6 participants
@alexwykoff @kjozwiak @bsclifton @evq @NejcZdovc @srirambv