Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Publisher added back after restart #12766

Closed
NejcZdovc opened this issue Jan 22, 2018 · 1 comment
Closed

Publisher added back after restart #12766

NejcZdovc opened this issue Jan 22, 2018 · 1 comment
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.21.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 22, 2018 •
edited by bsclifton
Loading

Description

Site is re-enabled when you restart browser and site was added when auto-include was on off.

Test plan / Steps to Reproduce

  1. Enable payments
  2. Disable auto-include
  3. Visit some sites (meet the visit/time criteria)
  4. Restart browser
  5. Publishers are re-enabled

Actual result:

image

Expected result:
image

Reproduces how often:

100%

Brave Version

about:brave info:

Brave: 0.19.134
rev: 316cfa5
Muon: 4.5.38
libchromiumcontent: 63.0.3239.132
V8: 6.3.292.49
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.3.0
OS Architecture: x64

Reproducible on current live release:

yes

Additional Information
@NejcZdovc NejcZdovc added this to the 0.20.x Hotfix 1 milestone Jan 22, 2018
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc
Fixes publisher exclude after restart
41a3d76 
Resolves brave#12766

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 22, 2018
Merged
10 tasks
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 19, 2018
@NejcZdovc @bsclifton
Fixes publisher exclude after restart
7f94309 
Resolves brave#12766

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 19, 2018
@bsclifton
Merge pull request #12767 from NejcZdovc/hotfix/#12766-include
0777c0e 
Fixes publisher exclude after restart
bsclifton added a commit that referenced this issue Feb 19, 2018
@bsclifton
Merge pull request #12767 from NejcZdovc/hotfix/#12766-include
833e0a4 
Fixes publisher exclude after restart
bsclifton added a commit that referenced this issue Feb 19, 2018
@bsclifton
Merge pull request #12767 from NejcZdovc/hotfix/#12766-include
b985e77 
Fixes publisher exclude after restart
This was referenced Feb 20, 2018
Closed
Closed
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #12767 from NejcZdovc/hotfix/#12766-include
2790d0d 
Fixes publisher exclude after restart
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Fixes publisher exclude after restart
00f5b58 
Resolves brave#12766

Auditors:

Test Plan:
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@kjozwiak kjozwiak mentioned this issue Feb 27, 2018
Closed
This was referenced Feb 27, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
6 participants
@alexwykoff @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski