Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

top site tiles not being populated when updating profile from 0.19.147 #12941

Closed
LaurenWags opened this issue Jan 30, 2018 · 7 comments · Fixed by #12968 or #13429
Closed

top site tiles not being populated when updating profile from 0.19.147 #12941

LaurenWags opened this issue Jan 30, 2018 · 7 comments · Fixed by #12968 or #13429
Assignees
@cezaraugusto
Labels
bug feature/topsites priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/not-blocking release-notes/include
Milestone
0.22.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Jan 30, 2018 •
edited by luixxiul
Loading

Test plan

#12968 (comment)

Description

I have a profile that I was using with version 0.19.147 which encountered issue #12027 (to the degree that I only have one (default, pinned) top site tile). When this profile was updated to 0.20.27 and I began to browse, I noticed my top site tiles were not being populated.

Steps to Reproduce

  1. Have a profile from 0.19.x that is missing top site tiles due to top site tiles go missing #12027
  2. Update profile to 0.20.27.
  3. Open a new tab, note you still have the one (default, pinned) top site tile.
  4. Browse normally (visit some sites in new tabs, etc).
  5. Open another new tab.

Actual result:
No new top site tiles added, only the default, pinned top site tile is displayed:
screen shot 2018-01-30 at 6 14 57 pm

Expected result:
Additional top site tiles should appear based on your browsing.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.20.27
V8 | 6.4.388.40
rev | 76102c5
Muon | 4.7.9
OS Release | 16.7.0
Update Channel | Release
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.119

Reproducible on current live release:
n/a

Additional Information

Missed when testing #12027
@LaurenWags LaurenWags added this to the 0.20.x Hotfix 2 milestone Jan 30, 2018
@bbondy bbondy modified the milestones: 0.20.x Hotfix 2, 0.20.x Hotfix 1 (Referral Promotion) Jan 31, 2018
@cezaraugusto cezaraugusto self-assigned this Jan 31, 2018
cezaraugusto added a commit that referenced this issue Feb 1, 2018
@cezaraugusto
clear old pinned items stored in wrong position
4d4d193 
fix #12941
@cezaraugusto cezaraugusto mentioned this issue Feb 1, 2018
Merged
@eljuno
Copy link
Contributor

eljuno commented Feb 2, 2018 •
edited
Loading

+2 from community https://community.brave.com/t/thumbnails-except-twitter-are-gone-from-dashboard/15289?u=eljuno

@LaurenWags
Copy link
Member Author

+1 from community: https://community.brave.com/t/add-home-screen-icons/15550

This was referenced Feb 10, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member Author

@cezaraugusto test plan works (0.19.x -> 0.20.x) but doesn't work when going from 0.20.30 (currently released version) to 0.20.40. I suspect a majority of users will be updating from 0.20.30 to the next 0.20 version.

@LaurenWags LaurenWags reopened this Feb 13, 2018
@bsclifton
Copy link
Member

@cezaraugusto the change you made only executes when upgrading from 0.19.x to 0.20.x (hence the behavior @LaurenWags reports). Is there another way we can detect this broken state (and fix)?

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Feb 14, 2018 •
edited
Loading

@bsclifton @cezaraugusto should we push this into 0.22 or in the backlog?

@bsclifton
Copy link
Member

bsclifton commented Feb 14, 2018 •
edited
Loading

@NejcZdovc let's push to 0.21 for now- if a quick fix comes in, we can consider doing a new build and
uplifting 😄

@bsclifton bsclifton modified the milestones: 0.20.x Release 2 (Referral Promotion), 0.21.x (Beta Channel) Feb 14, 2018
@alexwykoff alexwykoff added the priority/P3 Major loss of function. label Feb 27, 2018
cezaraugusto added a commit that referenced this issue Mar 12, 2018
@cezaraugusto
fix duplicated pinned top sites after update
d824096 
fix #12941
-
Some users upgrading from 0.20.x still experience the bug
that unallow usage of top sites in the newtab page.
changes in here ensure that pinned top sites are deduped at startup
cezaraugusto added a commit that referenced this issue Mar 13, 2018
@cezaraugusto
increase version range for pinnedTopSites cleanup
6186c92 
fix #12941
@cezaraugusto cezaraugusto mentioned this issue Mar 13, 2018
Merged
This was referenced Mar 22, 2018
Closed
Closed
Closed
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

@kjozwiak kjozwiak mentioned this issue Mar 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/topsites priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/not-blocking release-notes/include
Projects
None yet
Milestone
0.22.x (Release Channel)
10 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @eljuno @LaurenWags @btlechowski