Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When profile is corrupt, broken entries need to be pinned twice to stay pinned #13134

Closed
bsclifton opened this issue Feb 14, 2018 · 2 comments · Fixed by brave-intl/bat-publisher#13

Comments

@bsclifton
Copy link
Member

bsclifton commented Feb 14, 2018

When testing #13102, @kjozwiak and I noticed that the fix didn't solve the issue 100%.

We had to do the following steps to "fix" the issue:

  1. Have my profile (I have a backup- contact me; needs session-store-1 and ledger-state.json)
  2. Pin wikipedia.org
  3. Visit wikipedia.org for ~10 seconds
  4. Go to preferences#payments
  5. Notice wikipedia.org got unpinned
  6. Pin wikipedia.org again
  7. Visit wikipedia.org for ~10 seconds
  8. Go to preferences#payments
  9. Notice that pin stayed this time 😄
@kjozwiak
Copy link
Member

kjozwiak commented Feb 27, 2018

@bsclifton we'll need to go through this together on all three platforms like we did before. Hopefully you still have that profile available!

As a quick note for QA, I'll go through this issue with @bsclifton on all three platforms which involves his personal profile.

@kjozwiak
Copy link
Member

I went through the above issue with @bsclifton while we were on a Zoom call using his personal profile. We couldn't reproduce the issue with 0.21.16 a7bed47. Went through the following platforms:

  • Win 10 x64 VM - PASSED (couldn't reproduce the original issue)
  • Ubuntu 17.10 x64 VM - PASSED (couldn't reproduce the original issue)
  • macOS 10.13.3 x64 VM - PASSED (couldn't reproduce the original issue)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.