Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Twitch support #13139

Closed
NejcZdovc opened this issue Feb 14, 2018 · 2 comments
Closed

Add Twitch support #13139

NejcZdovc opened this issue Feb 14, 2018 · 2 comments
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.21.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

Description

Add support for Twitch into Brave Payments
@NejcZdovc NejcZdovc self-assigned this Feb 14, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 14, 2018
@NejcZdovc
Adds twitch support
b8b0d8e 
Resolves brave#13139

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 14, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 15, 2018
@NejcZdovc
Adds twitch support
09f2bba 
Resolves brave#13139

Auditors:

Test Plan:
@NejcZdovc NejcZdovc added this to the 0.21.x (Beta Channel) milestone Feb 15, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 15, 2018
@NejcZdovc
Adds twitch support
4b34edc 
Resolves brave#13139

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 20, 2018
@NejcZdovc
Adds twitch support
caa02db 
Resolves brave#13139

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 21, 2018
@NejcZdovc
Adds twitch support
e47adca 
Resolves brave#13139

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 21, 2018
@NejcZdovc
Adds twitch support
35ed23e 
Resolves brave#13139

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 22, 2018
@NejcZdovc
Adds twitch support
3fbf258 
Resolves brave#13139

Auditors:

Test Plan:
bsclifton pushed a commit to NejcZdovc/browser-laptop that referenced this issue Feb 22, 2018
@NejcZdovc @bsclifton
Adds twitch support
c54a1e3 
Resolves brave#13139

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 23, 2018
@NejcZdovc
Adds twitch support
b0738dc 
Resolves brave#13139

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 23, 2018
@bsclifton
Merge pull request #13142 from NejcZdovc/feature/#13139-twitch
e1738ad 
Adds twitch support
NejcZdovc pushed a commit that referenced this issue Feb 23, 2018
@bsclifton @NejcZdovc
Merge pull request #13142 from NejcZdovc/feature/#13139-twitch
33c7601 
Adds twitch support
NejcZdovc pushed a commit that referenced this issue Feb 23, 2018
@bsclifton @NejcZdovc
Merge pull request #13142 from NejcZdovc/feature/#13139-twitch
0f77c26 
Adds twitch support
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #13142 from NejcZdovc/feature/#13139-twitch
d39cb3c 
Adds twitch support
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Adds twitch support
18895d7 
Resolves brave#13139

Auditors:

Test Plan:
@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Feb 27, 2018 •
edited
Loading

Test Cases for Twitch Testing on MacOS:

  • Visit any Twitch VOD in a normal/session tab and ensure the video publisher name is listed in ledger table
  • Visit any Twitch Stream in a normal/session tab and ensure the video publisher name is listed in ledger table
  • Visit any Twitch VOD in a private tab and ensure the video publisher name is not listed in ledger table
  • Visit any Twitch Stream in a private tab and ensure the video publisher name is not listed in ledger table
  • Visit any Twitch VOD and ensure the time spent is shown under ledger table
  • Visit any Twitch Stream and ensure the time spent is shown under ledger table
  • Visit any embedded Twitch video (VOD or Stream) and ensure the video publisher name is listed in ledger table (use site from Add Twitch support #13139 (comment))
  • Ensure total time spent is correctly calculated for each Twitch publisher video (note, timing for twitch is slightly different then YT - heartbeats occur anywhere from 40s to 1min20s)
  • Ensure total time spent is correctly calculated when switching to Twitch video (Stream/VOD) from an embedded video (unable to locate a site for testing embedded Twitch)
  • Ensure Twitch publishers are not listed when Allow contributions to video is disabled in advanced settings
  • Ensure existing Twitch publishers are not lost when Allow contributions to video is disabled in advanced settings
  • Ensure Twitch publishers is listed but not included when auto-include is disabled
  • Update Advanced settings to different time/visit value and ensure Twitch videos (Stream/VOD) are added to ledger table once criteria is met
  • Perform a contribution while Twitch channels are included on the ledger. Ensure Twitch channels are listed on the contribution statement.
  • Verify able to delete Twitch publishers from ledger table.
  • Verify able to re-add Twitch publishers to ledger table
  • Verify if you minimize a Twitch video (Stream/VOD) and navigate around the site, the video is counted in ledger.
  • Verify when resume play on a Twitch VOD the time will continue to be counted in the ledger. (issue logged for this: Resume after pause on twitch media does not resume timer #13257)

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Feb 27, 2018 •
edited
Loading

@LaurenWags you can click on one of this for embedded videos https://www.joindota.com/en/livestreams (note you need to disable shields)

@kjozwiak kjozwiak mentioned this issue Feb 27, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Mar 12, 2018
Closed
@srirambv srirambv mentioned this issue Apr 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
6 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski