Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

pinned tabs do not retain order when moved with keyboard shortcut #13264

Closed
LaurenWags opened this issue Feb 22, 2018 · 1 comment
Closed

pinned tabs do not retain order when moved with keyboard shortcut #13264

LaurenWags opened this issue Feb 22, 2018 · 1 comment
Assignees
@petemill
Labels
0.21.x issue first seen in 0.21.x bug feature/keyboard-shortcuts feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 22, 2018 •
edited by bsclifton
Loading

Description

If you reorder your pinned tabs using the keyboard shortcut (ctrl+shift+pg up/down), and then close/reopen Brave, your pinned tabs order is not maintained.

Test plan / Steps to Reproduce

  1. Clean profile with 0.21.11.
  2. Open several tabs with several sites.
  3. Pin some of the tabs. Note pinned order.
  4. Move pinned tabs around using keyboard shortcut described in keyboard shortcuts to move a tab left or right #11313
  5. Note new order.
  6. Close/Reopen Brave.

Actual result:
Reordered pinned tabs are back to their original placement.

Expected result:
Pinned tabs should retain the order you set using the keyboard shortcut.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.21.11
V8 | 6.4.388.41
rev | e146cd8
Muon | 5.0.5
OS Release | 16.7.0
Update Channel | Beta
OS Architecture | x64
OS Platform | macOS
Node.js | 7.9.0
Brave Sync | v1.4.2
libchromiumcontent | 64.0.3282.140

Reproducible on current live release:
n/a

Additional Information

If you drag and drop pinned tabs into a new order this is kept.
@LaurenWags LaurenWags added this to the 0.21.x (Beta Channel) milestone Feb 22, 2018
@petemill petemill self-assigned this Feb 23, 2018
petemill added a commit that referenced this issue Feb 23, 2018
@petemill
Persist pinned tab order when a tab is moved by any means, such as ex…
d2700ae 
…tension, keyboard shortcut or drag.

Previously only dragging a pinned tab to a new order would cause the new order of pinned tabs to be persisted.

Fix #13264
@petemill petemill mentioned this issue Feb 23, 2018
Merged
10 tasks
ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@petemill @ryanml
Persist pinned tab order when a tab is moved by any means, such as ex…
8f0d554 
…tension, keyboard shortcut or drag.

Previously only dragging a pinned tab to a new order would cause the new order of pinned tabs to be persisted.

Fix brave#13264
This was referenced Mar 22, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018 •
edited by btlechowski
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
0.21.x issue first seen in 0.21.x bug feature/keyboard-shortcuts feature/pinned-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @bsclifton @srirambv @LaurenWags @btlechowski and others