Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

contribution notification displays again after toggle payments off/on #13287

Closed
LaurenWags opened this issue Feb 23, 2018 · 1 comment
Closed

Comments

@LaurenWags
Copy link
Member

Description

If you toggle payments off/on after a contribution is made, you get the contribution notification again.

Steps to Reproduce

  1. Launch 0.21.12 using LEDGER_ENVIRONMENT=staging
  2. visit about:preferences#payments and enable payments
  3. sites/YT videos
  4. close brave and fund the staging wallet.
  5. change reconcileStamp under ledger-state.json so Next Contribution is Overdue
  6. launch 0.21.12 using LEDGER_NO_DELAY=true LEDGER_NO_FUZZING=true LEDGER_VERBOSE=true LEDGER_ENVIRONMENT=staging
  7. wait till the contribution is made and you get a notification letting you know that X amount of BAT has been processed
  8. select OK on the banner notification
  9. Toggle Payments off/on

Actual result:
You get the contribution notification again.

contrib

Expected result:
No contribution notification.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.21.12

Reproducible on current live release:
Yes

Additional Information

Unsure if this should have been resolved by #12817 - that scenario has you turning notifications off, but here you are leaving them on.
cc @NejcZdovc

@NejcZdovc NejcZdovc self-assigned this Mar 12, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Mar 13, 2018
@bsclifton bsclifton added this to the Completed work milestone Mar 14, 2018
@NejcZdovc NejcZdovc modified the milestones: Completed work, 0.22.x (Beta Channel) Mar 21, 2018
NejcZdovc added a commit that referenced this issue Mar 21, 2018
NejcZdovc added a commit that referenced this issue Mar 21, 2018
NejcZdovc added a commit that referenced this issue Mar 21, 2018
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Went through verification using Ubuntu 17.10.1 x64 with the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.