Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update default top site icon for Brave.com #14008

Closed
Jacalz opened this issue May 3, 2018 · 2 comments
Closed

Update default top site icon for Brave.com #14008

Jacalz opened this issue May 3, 2018 · 2 comments
Assignees
@Jacalz
Labels
feature/newtab misc/favicon QA/no-qa-needed release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@Jacalz
Copy link
Contributor

Jacalz commented May 3, 2018 •
edited by bsclifton
Loading

Description

The logo on about:newtab is the old one and thus needs an update in order too look a bit better 👍

Test plan / Steps to Reproduce

  1. Open Brave with a fresh session file
  2. Go to about:newtab

Actual result:
image

Expected result:
Should have this log instead:
brave

Reproducible on current live release:
yes

Additional Information

I willl be taking a shot at updating this so expect a PR soon 🙂
@Jacalz Jacalz self-assigned this May 3, 2018
@Jacalz
Copy link
Contributor Author

Jacalz commented May 3, 2018

PR created and ready for prime time 🙂

@Jacalz Jacalz mentioned this issue May 3, 2018
Merged
3 tasks
@bsclifton bsclifton changed the title Top sites tile needs an update Update top site icon for Brave.com May 3, 2018
@bsclifton bsclifton changed the title Update top site icon for Brave.com Update default top site icon for Brave.com May 3, 2018
@bsclifton bsclifton added this to the 0.23.x (Developer Channel) milestone May 3, 2018
@Jacalz
Copy link
Contributor Author

Jacalz commented May 6, 2018

It looks like this with the new PR:
image

bsclifton added a commit that referenced this issue May 7, 2018
@bsclifton
Merge pull request #14009 from Jacalz/master
ed7b2b4 
Change to new Brave logo on top sites tile #14008
bsclifton added a commit that referenced this issue May 7, 2018
@bsclifton
Merge pull request #14009 from Jacalz/master
4d07ed3 
Change to new Brave logo on top sites tile #14008
This was referenced Jun 19, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jacalz Jacalz

Labels
feature/newtab misc/favicon QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
4 participants
@kjozwiak @bsclifton @srirambv @Jacalz