Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

YouTube channels not showing verified icon on ledger table #14351

Closed
LaurenWags opened this issue Jun 7, 2018 · 5 comments
Closed

YouTube channels not showing verified icon on ledger table #14351

LaurenWags opened this issue Jun 7, 2018 · 5 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.23.x (Release C...

Comments

@LaurenWags
Copy link
Member

Description

YouTube channels are not showing the verified icon.

Reported via community: https://community.brave.com/t/significant-new-bug-in-payments-ui-since-recent-update-channel-names-verification/23278/2

Steps to Reproduce

  1. Enable Payments.
  2. Visit a site like DDG (or other verified site) for a bit.
  3. Visit ledger table, DDG is listed and shows verified icon.
  4. Watch a video on a verified YT site. I used videos from: https://www.youtube.com/user/RubinReport/videos
    https://www.youtube.com/user/sxephil/videos
    https://www.youtube.com/user/BartBaKer/videos
  5. Visit ledger table.

Actual result:
YT channels are listed but no verified icons display.
screen shot 2018-06-07 at 10 33 54 am

Expected result:
YT sites should show as verified.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.22.727

Reproducible on current live release:
Yes

Additional Information
@NejcZdovc
Copy link
Contributor

looks like media publishers are not returning verified state

Bart (media publisher): https://ledger.mercury.basicattentiontoken.org/v3/publisher/identity?publisher=youtube%23channel%3ABartBaKer not working

Clifton (regular site): https://ledger.mercury.basicattentiontoken.org/v3/publisher/identity?publisher=clifton.io working

@kjozwiak
Copy link
Member

kjozwiak commented Jun 12, 2018 •
edited
Loading

Any news on this? Probably should get this fixed sooner rather than later. Is this a server side issue or something on the client side?

@evq
Copy link
Member

evq commented Jun 12, 2018

We are in the process of moving this API to publishers, it is most likely a server side issue in the current implementation in ledger. We will verify that the new implementation works correctly for youtube channels such as the above and push on performing the switchover

@kjozwiak
Copy link
Member

@evq let me know if you need any help from QA.

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned mrose17 and evq Jun 18, 2018
@NejcZdovc NejcZdovc modified the milestone: 0.23.x (Beta Channel) Jun 21, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 21, 2018
@NejcZdovc
Fixes verfied check for YouTube
bbee6f1 
Resolves brave#14351

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jun 21, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 21, 2018
@NejcZdovc
Fixes verfied check for YouTube
351a5c4 
Resolves brave#14351

Auditors:

Test Plan:
@bsclifton bsclifton added this to the 0.23.x (Beta Channel) milestone Jun 21, 2018
bsclifton added a commit that referenced this issue Jun 21, 2018
@bsclifton
Merge pull request #14485 from NejcZdovc/fix/#14351-verified
52838d0 
Fixes verfied check for YouTube
bsclifton added a commit that referenced this issue Jun 21, 2018
@bsclifton
Merge pull request #14485 from NejcZdovc/fix/#14351-verified
febef50 
Fixes verfied check for YouTube
bsclifton added a commit that referenced this issue Jun 21, 2018
@bsclifton
Merge pull request #14485 from NejcZdovc/fix/#14351-verified
2d69694 
Fixes verfied check for YouTube
This was referenced Jun 21, 2018
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jun 22, 2018
Closed
@LaurenWags
Copy link
Member Author

LaurenWags commented Jun 22, 2018 •
edited by srirambv
Loading

Verified with macOS 10.12.6 using

  • 0.23.14 f4da855
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87

Verified on Ubuntu 17.10 x64

  • 0.23.14 - f4da855
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87

@kjozwiak kjozwiak mentioned this issue Jun 25, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
8 participants
@mrose17 @kjozwiak @bsclifton @evq @NejcZdovc @srirambv @LaurenWags @btlechowski