Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Site specific script unblocking has no effect on URL containing an IP address. #2988

Closed
DivineOmega opened this issue Aug 5, 2016 · 1 comment

Comments

@DivineOmega
Copy link

DivineOmega commented Aug 5, 2016

Test plan

#7378 (comment)


Did you search for similar issues before submitting this one? Yup.

Describe the issue you encountered: With script blocking in the global Bravery settings, trying to unblock scripts in site-specific Bravery settings has no affect if the URL contains an IP address (and perhaps port number).

Expected behavior: Site-specific script unblocking should work regardless of the URL.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Tested on Linux (Ubuntu 16.04)
  • Brave Version: 0.11.2
  • Steps to reproduce:
    1. Enable script blocking in the global Bravery settings.
    2. Navigate to a JavaScript powered webpage containing an IP address in its URL, rather than a domain name.
    3. Attempt to unblock scripts in the site-specific Bravery settings (or disable shields).
    4. Notice that scripts still fail to work.

I've tested this issue with local (127.0.0.1) and LAN (192.168.1.*) IPs.

@DivineOmega
Copy link
Author

This issue still seems present in the v0.11.3 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants