Start suggestions after first character not second

[bbondy]

Currently you have to hit 2 characters for suggestions to show up. We should appear after just one char instead.

[Sh1d0w]

I guess this is related to #3151 , but in case you want this fixed asap, I have opened a PR.

Not sure this is the correct fix tho. The componentDidUpdate is not triggered when you type the first letter for some reason (in windowStore suggestionList is null) nor componentShouldUpdate despite the fact urlLocation property passed from UrlBar component is not empty. But if you type two letters, delete and then type only one it will show (suggestionList is actual list now).

The only workaround I could find is to populate the list when the component mounts for first time.

[bbondy]

I think #3151 is the root cause of this problem ya. It's a big ugly refactor though. If you feel "brave" and want to tackle it though.. ;)

Might be best done in parts like first moving the search suggestions up into the store.

[bbondy]

Re-opening I think it's causing an issue that Brad will post an image for. I'm leaving committed though s please just do a second PR for it if you can.

[Sh1d0w]

Sure. Just let me know what is the issue.

[bradleyrichter]

suggestions should not open when clicking on the new tab:

[Sh1d0w]

@bradleyrichter I can't reproduce this on latest master. Can you please provide STR? Have you typed anything in the url bar and then deleted?

[Sh1d0w]

Here is a video from latest freshly check-outed master: http://webm.land/media/rJCm.webm

[luixxiul]

Please check #4900 too, about:newtab in History on the autosuggest list.

[bbondy]

I could reproduce earlier today but I am no longer able to. Maybe it was fixed as part of something else since then. If someone reproduces please re-open.