Window corners have border radius

[bsclifton]

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Borders should be consistent, regardless of Windows version. Windows 7 typically shows rounded borders and Windows 8/10 show square edges.

Expected behavior:
Border looks correct

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Windows 7
• Brave Version:
  0.12.2 RC2
• Steps to reproduce:
  1. Launch Brave
  2. look at window corners
  3. If window corners look OK, try maximizing then restoring
• Screenshot if needed:
  
• Any related issues: Titlebar on Windows has a lot of wasted space #3036

[bridiver]

border gap is only visible against a light background

[bsclifton]

Unfortunately, not completely fixed with #4342

High DPI versions would always show white in the corners:

Potential solution offered by @bbondy would be to fix this in electron. We should be able to hide the corner regions using win32 call SetLayeredWindowAttributes

[jonathansampson]

0.13.0 build (on Windows 10) from January 14, 2017

[bsclifton]

Updated notes; this was also noticed today when I upstreamed recent DPI fixes:
electron/electron#8404

I believe the problem is the approach I took for cancelling out non-client area. Setting an inset of 0,0 might be the approach we have to take, since the styles being generated for the window are unusual.

[bsclifton]

I believe I have the fix for this

@kevinsawicki noticed this issue when I upstreamed the DPI fix to electron. I went back to the previous way I was handling non-client area and this fixed the issue.

Fixed in my electron PR with electron/electron@9e0547b; I'll submit a PR for muon tomorrow after testing with browser-laptop-bootstrap

[srirambv]

The blue window border is visible/not visible upon restarts.

Outline not visible on right and bottom of the browser window

Outline not visible on the bottom but on all other sides after restart

[bsclifton]

We'll want to test this on Windows 7. The borders should ideally NOT be rounded there... if they are, we can open a new issue.

[srirambv]

Works fine on Windows 10 on preview 9

[bsclifton]

Unfortunately, this is still an issue on Windows 7 (captured with brave/muon#145)

To be clear, the behavior hasn't changed for Windows 7. Windows 10 was experiencing an issue which caused it to have the same problem as Windows 7 and instead of making a new ticket, we updated this one. The issue seen in Windows 10 was introduced with 0.13.0 and was closed with brave/muon#144

edit:
I created a follow up issue in the Muon repository, which is more appropriate (because the Windows 7 issue is NOT an issue with browser-laptop)
brave/muon#145