Update Favicons doesnt work as expected

[srirambv]

Did you search for similar issues before submitting this one?

Describe the issue you encountered:
Update Favicons works as expected

Expected behavior:
Favicons should be updated for both Browser import and HTML File import

• Platform (Win7, 8, 10? macOS? Linux distro?):
  Ubuntu 16.04
• Brave Version:
  0.12.3 dev-RC1
• Steps to reproduce:
  1. User created bookmarks doesn't show favicon shows title as well when show only fav icons is enabled
  2. Other existing boookmarks doesn't show icons either under nested folders or just bookmark items
  3. Imported bookmarks from HTML file doesn't show icons.
• Screenshot if needed:
  
• Any related issues:
  Update favicon of imported items #4270 Update favicon from importer #4271

cc: @darkdh

[darkdh]

I thought the bookmarks under folders will also show title is intended when show only favicon is on. @bsclifton ?

[bsclifton]

@darkdh that is correct- it was originally implemented with only top level bookmarks hiding the titles. Now, top level folders hide the titles. Any child item should be showing the titles though

[bbondy]

This is moved into 0.12.4 btw. Users can re-import to fix.

[alexwykoff]

Confirmed still an issue in 0.12.3 RC6. Re-importing did not fix the favicons.

[darkdh]

because #4345 is not merged.

[srirambv]

Reopening the issue. Website Favicons not loaded but shows an empty file icon for all bookmarks which makes it impossible to know what bookmark is for which site if only favicons is set.
0.12.4 Preview1

[darkdh]

@srirambv brave/muon@v1.4.10...master the electron changes didn't be include in electron release for preview 1 and 2. Please hold it until RC 1

[bbondy]

Closing but please test it after electron changes higher than 1.4.10.