Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Private tab preferences #4468

Closed
darkdh opened this issue Oct 3, 2016 · 1 comment · Fixed by #4469
Closed

Private tab preferences #4468

darkdh opened this issue Oct 3, 2016 · 1 comment · Fixed by #4469
Assignees
@darkdh
Labels
feature/private-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.4dev

Comments

@darkdh
Copy link
Member

darkdh commented Oct 3, 2016

Make bravery panel, site permissions, mixed content...(temporarySiteSettings) works in private tab.
@darkdh darkdh added this to the 0.12.4dev milestone Oct 3, 2016
@darkdh darkdh self-assigned this Oct 3, 2016
darkdh added a commit that referenced this issue Oct 3, 2016
@darkdh
Using temporarySiteSettings to store private tab preferences
b347a96 
fix #4468

Auditors: @bbondy, @bridiver

Test Plan:
Test bravery panel, site permissions, mixed content, flash in private tabs and the preferences should not write to disk and affect regular tabs
@darkdh darkdh mentioned this issue Oct 3, 2016
Merged
4 tasks
@diracdeltas
Copy link
Member

a subtask of this is #1824

@diracdeltas diracdeltas mentioned this issue Oct 4, 2016
Closed
This was referenced Oct 4, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 5, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 7, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/private-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.4dev
Development

Successfully merging a pull request may close this issue.

Using temporarySiteSettings to store private tab preferences brave/browser-laptop
6 participants
@aekeus @diracdeltas @alexwykoff @luixxiul @darkdh @srirambv