Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:history multi-selection delete does not remove the entries selected #4741

Closed
alexwykoff opened this issue Oct 13, 2016 · 2 comments · Fixed by #4750
Closed

about:history multi-selection delete does not remove the entries selected #4741

alexwykoff opened this issue Oct 13, 2016 · 2 comments · Fixed by #4750
Assignees
@darkdh
Labels
feature/history QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.5dev

Comments

@alexwykoff
Copy link
Contributor

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Having selected multiple entries in about:history and attempting to delete them via the context menu, it appears as though other entries were deleted.

Expected behavior:
The selected entries should be deleted.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.12.5 Preview2
  • Steps to reproduce:
    1. Visit a lot of places
    2. Select a few in about:history using the multiselect feature (I also sorted the columns)
    3. Delete the selected items via the context menu
  • Screenshot if needed:
    multiselect_history
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.12.5dev milestone Oct 13, 2016
@luixxiul
Copy link
Contributor

If someone gets this please check this too: #4738 which seems to be similar with this.

@bsclifton
Copy link
Member

@darkdh and I tried to reproduce, unsuccessfully. I wonder if this symptom is the same as #4224 ?

@darkdh darkdh self-assigned this Oct 13, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 13, 2016
@darkdh
Fix global table indexing
809b61d 
fix brave#4741

Auditors: @bsclifton

Test Plan:
1. go to about:history
2. sort the table
3. multi select entries
4. right click on them
5. perform any actions in context menu
6. the action tagets should be correct
@darkdh darkdh mentioned this issue Oct 13, 2016
Merged
4 tasks
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 13, 2016
@darkdh
Fix global table indexing
00f7026 
fix brave#4741

Auditors: @bsclifton

Test Plan:
1. go to about:history
2. sort the table
3. multi select entries
4. right click on them
5. perform any actions in context menu
6. the action tagets should be correct
This was referenced Oct 14, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 16, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
feature/history QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.5dev
Development

Successfully merging a pull request may close this issue.

Fix global table indexing darkdh/browser-laptop
5 participants
@alexwykoff @luixxiul @bsclifton @darkdh @srirambv