Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

regression: date format of next contribution not localized #4787

Closed
luixxiul opened this issue Oct 14, 2016 · 1 comment
Closed

regression: date format of next contribution not localized #4787

luixxiul opened this issue Oct 14, 2016 · 1 comment
Assignees
@ayumi
Labels
feature/rewards l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Milestone
0.12.8dev

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 14, 2016 •
edited
Loading

Describe the issue you encountered: date format of next contribution is not localized. You can see "in 21 days" on the screenshot below.

clipboard01

Expected behavior: It should be localized.
@mrose17 mrose17 added this to the 0.12.7dev milestone Oct 17, 2016
@brave-office brave-office modified the milestones: 1.0.0, 0.12.7dev Oct 18, 2016
@mrose17 mrose17 modified the milestones: 0.12.7dev, 1.0.0, 0.12.8dev Oct 22, 2016
@ayumi ayumi self-assigned this Oct 25, 2016
ayumi added a commit that referenced this issue Oct 31, 2016
@ayumi
Set preferences moment locale to navigator.language
ebc19be 
Fix #4787

Auditors: @@luixxiul

Test Plan:
1. Set language to non English. restart if needed.
2. See Preferences > Payments, "Contribution due date: {due date}" due date should be localized
3. Try 1+2 for another language
@ayumi ayumi mentioned this issue Oct 31, 2016
Merged
This was referenced Nov 2, 2016
Closed
Closed
Closed
@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 3, 2016

pasted image at 2016_11_03 01_37 pm

Note for QA: in Japanese, if you write vertically you are expected to use Japanese characters, which is 一 for 1, 二 for 2, 四 for 4 etc. But horizontally you are expected to use numerical values. So 1ヶ月後 (which is "in a month" in English) sounds native and is no problem. Thanks @srirambv for pinging me on it :-)

This was referenced Nov 4, 2016
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ayumi ayumi

Labels
feature/rewards l10n QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 regression
Projects
None yet
Milestone
0.12.8dev
Development

No branches or pull requests
6 participants
@mrose17 @ayumi @alexwykoff @luixxiul @srirambv @brave-office