Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Set 2 visits on minimum visit for publisher relevancy and automatically back to 5 #4822

Closed
bitcoinuser opened this issue Oct 15, 2016 · 5 comments

Comments

@bitcoinuser
Copy link

Did you search for similar issues before submitting this one? Yes

Describe the issue you encountered:

I set 2 visits on minimum visit for publisher relevancy and automatically back to 5

Expected behavior:

Keep on 2

  • Platform (Win7, 8, 10? macOS? Linux distro?): Ubuntu 64
  • Brave Version: Dev Channel Beta v0.12.5dev-RC1
  • Steps to reproduce:
    1. Go to preferences/payment
      2.Open advanced settings
    2. Set 2 visits

Obs. See the video uploaded to understand the problem
Brave.ogv.zip

@jkup jkup self-assigned this Nov 4, 2016
@jkup
Copy link
Contributor

jkup commented Nov 4, 2016

Also heard that dropping the number of visits clears out the ledger list. Going to look into both for this ticket.

@bitcoinuser
Copy link
Author

Also heard that dropping the number of visits clears out the ledger list

Happened with me too.

@mrose17 mrose17 added this to the 0.12.11 milestone Nov 8, 2016
@jkup
Copy link
Contributor

jkup commented Nov 15, 2016

Looking into this now. I suspect this started happening from this commit 42146a3

@jkup
Copy link
Contributor

jkup commented Nov 17, 2016

Update: I think the clearing of the ledger list is working as designed. If you don't have any entries with 10+ visits and you change your minimum visits to 10 they should all disappear.

Still investigating the choice not persisting!

ledger

@luixxiul
Copy link
Contributor

Test plan: #5824 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants