Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Set as default browser switch should not show default UI #4934

Closed
bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by #4942
Closed

Set as default browser switch should not show default UI #4934

bbondy opened this issue Oct 19, 2016 · 0 comments · Fixed by #4942
Assignees
@darkdh
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 settings
Milestone
0.12.6dev

Comments

@bbondy
Copy link
Member

bbondy commented Oct 19, 2016

  1. Turn off always check on startup
  2. Close app
  3. Open app
  4. Go to preferences
  5. Toggle the switch for always check on startup

Actual results:
It pops up the Ready to make Brave your default browser?

Expected results:
It should only have an effect for the next time you open Brave it would show on startup.
The dialog should only show up on startup or if you click the set as default... button.
@bbondy bbondy added this to the 0.12.6dev milestone Oct 19, 2016
darkdh added a commit to darkdh/browser-laptop that referenced this issue Oct 19, 2016
@darkdh
Delete "defaultBrowserCheckComplete" only when check on startup is on
449e40d 
fix brave#4934

Auditors: @bbondy

Test Plan:
1. Turn off always check on startup
2. Close app
3. Open app
4. Go to preferences
5. Toggle the switch for always check on startup
@darkdh darkdh mentioned this issue Oct 19, 2016
Merged
4 tasks
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 settings
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Delete "defaultBrowserCheckComplete" only when check on startup is on darkdh/browser-laptop
5 participants
@bbondy @alexwykoff @luixxiul @darkdh @srirambv