Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When sorting items in the autocomplete, disregard the www. prefix #4955

Closed
aekeus opened this issue Oct 19, 2016 · 0 comments
Closed

When sorting items in the autocomplete, disregard the www. prefix #4955

aekeus opened this issue Oct 19, 2016 · 0 comments
Assignees
@aekeus
Labels
bug
Milestone
0.12.6dev

Comments

@aekeus
Copy link
Member

aekeus commented Oct 19, 2016

In the autocomplete sorting mechanism, the www. prefix portion of the location should be removed before the sorting occurs. This will allow locations without the www. prefix to sort correctly when compared with items containing the www. prefix

Related to :#3049

cc @bbondy @Sh1d0w @alexwykoff
@aekeus aekeus added the bug label Oct 19, 2016
@aekeus aekeus added this to the 0.12.7dev milestone Oct 19, 2016
@aekeus aekeus self-assigned this Oct 19, 2016
aekeus added a commit that referenced this issue Oct 19, 2016
@aekeus
Normalize the location string for a history item by removing the www.…
af81313 
… prefix

before sorting.

Auditors: @bbondy

Test Plan:

  1. Clear session file
  2. Visit twitter.com once
  3. Visit twilio.com once
  4. Close both tabs
  5. Open a new tab and enter the string 'twi'
  6. Ensure www.twilio.com is the first entry (as it was visited most recently and has the same visit count value)

Fixes: #4955
@aekeus aekeus mentioned this issue Oct 19, 2016
Merged
4 tasks
@Sh1d0w Sh1d0w mentioned this issue Oct 20, 2016
Closed
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.7dev Oct 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
bug
Projects
None yet
Milestone
0.12.6dev
Development

No branches or pull requests
2 participants
@aekeus @bbondy