Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Clicking on Allow protocol registration opens up system settings #5028

Closed
srirambv opened this issue Oct 21, 2016 · 6 comments · Fixed by brave/muon#77
Closed

Clicking on Allow protocol registration opens up system settings #5028

srirambv opened this issue Oct 21, 2016 · 6 comments · Fixed by brave/muon#77
Assignees
@darkdh
Labels
OS/Windows QA/checked-Linux QA/checked-macOS regression
Milestone
0.12.6dev

Comments

@srirambv
Copy link
Collaborator

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Clicking on Allow protocol registration opens up system settings

Expected behavior:
Should not open system settings when user clicks on allow protocol registration

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.6 Preview 2
  • Steps to reproduce:
    1. Visit https://jsfiddle.net/LnwtLckc/5/
    2. Click on register
    3. Click on Allow in the notification bar, launches system settings
  • Screenshot if needed:
    protocol
  • Any related issues:

cc: @bridiver
@srirambv srirambv added this to the 0.12.7dev milestone Oct 21, 2016
@darkdh
Copy link
Member

darkdh commented Oct 21, 2016

This is related to the default browser check change
brave/muon@016f564#diff-7a9e5593d6e972d1c03555df84e6412cR241

@darkdh darkdh self-assigned this Oct 21, 2016
@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.7dev Oct 21, 2016
@bbondy
Copy link
Member

bbondy commented Oct 21, 2016

this one is pretty bad and should go in 0.12.6

@bbondy
Copy link
Member

bbondy commented Oct 21, 2016

also adding regression label

darkdh added a commit to darkdh/electron that referenced this issue Oct 21, 2016
@darkdh
Temporary solution for solving conflict between RegisterProtocolHandler
8d6a6ed 
and Set Default Browser

fix brave/browser-laptop#5028

Auditors: @bbondy, @bridiver
@darkdh darkdh mentioned this issue Oct 21, 2016
Merged
This was referenced Oct 22, 2016
Closed
Closed
Closed
Closed
@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

Sorry RC1 didn't have the new electron, I'll do it for RC2 though.

@bbondy
Copy link
Member

bbondy commented Oct 22, 2016 •
edited
Loading

Will be in brave/electron 1.4.19

@bbondy
Copy link
Member

bbondy commented Oct 22, 2016

Correction, brave/electron 1.4.18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
OS/Windows QA/checked-Linux QA/checked-macOS regression
Projects
None yet
Milestone
0.12.6dev
Development

Successfully merging a pull request may close this issue.

Temporary solution for solving conflict between RegisterProtocolHandler darkdh/electron
4 participants
@bbondy @alexwykoff @darkdh @srirambv