Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:history omits recent history #5072

Closed
CliqueBait opened this issue Oct 23, 2016 · 5 comments
Closed

about:history omits recent history #5072

CliqueBait opened this issue Oct 23, 2016 · 5 comments
Assignees
@NejcZdovc
Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@CliqueBait
Copy link

CliqueBait commented Oct 23, 2016 •
edited by luixxiul
Loading

Test plan

#10136 (comment)

Also make sure your history more than one month remains

about:history only displays browsing history more than ~22h57m old. History data seems correct as missing browsing history does appear once sufficient time has passed but the display should include everything upto the most recent browsing history.

Ubuntu 16.10
Brave: 0.12.5
Electron: 1.4.14
libchromiumcontent: 53.0.2785.143
V8: 5.3.332.47
Node.js: 6.5.0
Update Channel: dev
@privatzee
Copy link
Contributor

privatzee commented Oct 23, 2016 •
edited by luixxiul
Loading

#4224

Win7 x64
Brave 0.12.5

History is so wrong that I'd stopped using it.

atm, my most recent entry in about:history is ~6 hours old. What appears on the History menu dropdown from the menu bar doesn't match that and is all jumbled besides.

@Sh1d0w Sh1d0w mentioned this issue Oct 23, 2016
Closed
6 tasks
@privatzee privatzee mentioned this issue Oct 26, 2016
Closed
@Sh1d0w
Copy link

Sh1d0w commented Oct 27, 2016

Probably related issue #4794

@CliqueBait
Copy link
Author

@Sh1d0w I don't think so. My guess is that there's a timestamp-based query which doesn't correctly account for the user's timezone.

@bsclifton bsclifton added this to the 0.12.10 release milestone Nov 11, 2016
@bsclifton bsclifton self-assigned this Nov 11, 2016
@bsclifton bsclifton mentioned this issue Nov 11, 2016
Closed
4 tasks
@bsclifton bsclifton removed this from the 0.12.10 release milestone Nov 14, 2016
@bsclifton bsclifton removed their assignment Nov 14, 2016
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
@NejcZdovc NejcZdovc mentioned this issue Jul 20, 2017
Closed
8 tasks
@luixxiul luixxiul added this to the 0.20.x (Developer Channel) milestone Jul 20, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Jul 20, 2017 •
edited by NejcZdovc
Loading

Adding the same milestone as #10136, which would possibly fix this issue.

@NejcZdovc NejcZdovc self-assigned this Jul 26, 2017
@NejcZdovc NejcZdovc mentioned this issue Jul 26, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Nightly Channel), 0.20.x (Developer Channel) Aug 4, 2017
NejcZdovc added a commit that referenced this issue Aug 4, 2017
@NejcZdovc
Splits sites object in the app state
c2fd650 
Resolves #1646
Resolves #1856
Resolves #2655
Resolves #2771
Resolves #3646
Resolves #3694
Resolves #4224
Resolves #4260
Resolves #4833
Resolves #4868
Resolves #4929
Resolves #5072
Resolves #5699
Resolves #5382
Resolves #6104
Resolves #6108
Resolves #6585
Resolves #8022
Resolves #9301
Resolves #9326
Resolves #9978
Resolves #10026

Auditors:

Test Plan:
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@NejcZdovc @dfperry5
Splits sites object in the app state
33861b7 
Resolves brave#1646
Resolves brave#1856
Resolves brave#2655
Resolves brave#2771
Resolves brave#3646
Resolves brave#3694
Resolves brave#4224
Resolves brave#4260
Resolves brave#4833
Resolves brave#4868
Resolves brave#4929
Resolves brave#5072
Resolves brave#5699
Resolves brave#5382
Resolves brave#6104
Resolves brave#6108
Resolves brave#6585
Resolves brave#8022
Resolves brave#9301
Resolves brave#9326
Resolves brave#9978
Resolves brave#10026

Auditors:

Test Plan:
@bbondy bbondy removed this from the 0.21.x (Developer Channel) milestone Oct 25, 2017
@bbondy bbondy added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
This was referenced Dec 20, 2017
Closed
Closed
@srirambv
Copy link
Collaborator

Verified by changing system time to see if the history was retained in browser
image

This was referenced Dec 27, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/history QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

History fixes and misc about page fixes
9 participants
@bbondy @luixxiul @bsclifton @Sh1d0w @NejcZdovc @CliqueBait @srirambv @privatzee @LaurenWags